You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/08 14:55:03 UTC
[GitHub] [spark] zero323 opened a new pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
zero323 opened a new pull request #29978:
URL: https://github.com/apache/spark/pull/29978
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
- Annotated return types of `assert_true` and `raise_error` as discussed [here](https://github.com/apache/spark/pull/29947#pullrequestreview-504495801).
- Add `assert_true` and `raise_error` to SparkR NAMESPACE.
- Validating message vector size in SparkR as discussed [here](https://github.com/apache/spark/pull/29947#pullrequestreview-504539004)
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
As discussed in review for #29947.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
- Existing tests.
- Validation of annotations using MyPy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705629891
**[Test build #129559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129559/testReport)** for PR 29978 at commit [`4da2633`](https://github.com/apache/spark/commit/4da263309a86c33d355625319d15ff4c1fdcade0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705993393
Thanks @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705671966
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705671966
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29978:
URL: https://github.com/apache/spark/pull/29978
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705670825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 closed pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #29978:
URL: https://github.com/apache/spark/pull/29978
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705629891
**[Test build #129559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129559/testReport)** for PR 29978 at commit [`4da2633`](https://github.com/apache/spark/commit/4da263309a86c33d355625319d15ff4c1fdcade0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705629891
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705658427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705658427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705902761
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 closed pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #29978:
URL: https://github.com/apache/spark/pull/29978
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705658697
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34165/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705658427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705670825
Seems like some transient dependency download problem. From [log](https://github.com/apache/spark/pull/29978/checks?check_run_id=1226588518):
```
2020-10-08T14:57:27.9993390Z trying URL 'https://cloud.r-project.org/src/contrib/clipr_0.7.0.tar.gz'
2020-10-08T14:57:28.2725809Z Error in download.file(url, destfile, method, mode = "wb", ...) :
2020-10-08T14:57:28.2727982Z cannot open URL 'https://cloud.r-project.org/src/contrib/clipr_0.7.0.tar.gz'
2020-10-08T14:57:28.2728950Z In addition: Warning message:
2020-10-08T14:57:28.2729732Z In download.file(url, destfile, method, mode = "wb", ...) :
2020-10-08T14:57:28.2731349Z cannot open URL 'https://cloud.r-project.org/src/contrib/clipr_0.7.0.tar.gz': HTTP status was '403 Forbidden'
2020-10-08T14:57:28.2736724Z Warning in download.packages(pkgs, destdir = tmpd, available = available, :
2020-10-08T14:57:28.2738325Z download of package ‘clipr’ failed
...
2020-10-08T15:14:37.9338172Z ERROR: dependency ‘clipr’ is not available for package ‘usethis’
2020-10-08T15:14:37.9340098Z * removing ‘/opt/R/4.0.2/lib/R/library/usethis’
2020-10-08T15:14:38.3379035Z ERROR: dependency ‘usethis’ is not available for package ‘devtools’
2020-10-08T15:14:38.3381052Z * removing ‘/opt/R/4.0.2/lib/R/library/devtools’
2020-10-08T15:14:38.3545924Z
2020-10-08T15:14:38.3546960Z The downloaded source packages are in
2020-10-08T15:14:38.3548598Z ‘/tmp/Rtmp9gUv8b/downloaded_packages’
2020-10-08T15:14:38.3550043Z Updating HTML index of packages in '.Library'
2020-10-08T15:14:38.3887924Z Making 'packages.html' ... done
2020-10-08T15:14:38.3888839Z Warning messages:
2020-10-08T15:14:38.3889644Z 1: In install.packages(c("knitr", "rmarkdown", "testthat", "devtools", :
2020-10-08T15:14:38.3890687Z installation of package ‘usethis’ had non-zero exit status
2020-10-08T15:14:38.3891476Z 2: In install.packages(c("knitr", "rmarkdown", "testthat", "devtools", :
2020-10-08T15:14:38.3892950Z installation of package ‘devtools’ had non-zero exit status
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705658427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29978:
URL: https://github.com/apache/spark/pull/29978
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705902761
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705671944
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34165/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705657942
**[Test build #129559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129559/testReport)** for PR 29978 at commit [`4da2633`](https://github.com/apache/spark/commit/4da263309a86c33d355625319d15ff4c1fdcade0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29978: [SPARK-32793][FOLLOW-UP] Minor corrections for PySpark annotations and SparkR
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29978:
URL: https://github.com/apache/spark/pull/29978#issuecomment-705629891
**[Test build #129559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129559/testReport)** for PR 29978 at commit [`4da2633`](https://github.com/apache/spark/commit/4da263309a86c33d355625319d15ff4c1fdcade0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org