You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jesse McConnell (JIRA)" <ji...@codehaus.org> on 2006/08/15 04:44:49 UTC
[jira] Created: (CONTINUUM-814) change ContinuumActionSupport to
ContinuumConfigurationInterceptor
change ContinuumActionSupport to ContinuumConfigurationInterceptor
------------------------------------------------------------------
Key: CONTINUUM-814
URL: http://jira.codehaus.org/browse/CONTINUUM-814
Project: Continuum
Issue Type: Improvement
Components: Web interface
Reporter: Jesse McConnell
Attachments: configuration-interceptor.patch
a bit ago I submitted a patch in CONTINUUM-810 that added a ContinuumActionSupport class that leveraged the prepare interceptor to always call a prepare() method checking if the continuum configuration was initialized and if it wasn't to redirect to configuration.
well shortly after that brett pointed me at how he had solved it in mrm so I figured I would just back out that previous patch and redo it his way..
that is what this patch does, makes the continuum configuration checking match that of mrm.
as a byproduct of this the xwork.xml file now has multiple packages and namespaces in it, so I took the oppurtunity to move all of the jsps into src/main/webapp/jsp and the configuration ones into src/main/webapp/jsp/admin
this is largely cosmetic but it cleans up the -webapp module in ide's and I was in the xwork.xml file anyway.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (CONTINUUM-814) change ContinuumActionSupport to
ContinuumConfigurationInterceptor
Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse McConnell closed CONTINUUM-814.
-------------------------------------
Assignee: Jesse McConnell
Resolution: Fixed
Fix Version/s: 1.1-alpha-1
did this ages ago
> change ContinuumActionSupport to ContinuumConfigurationInterceptor
> ------------------------------------------------------------------
>
> Key: CONTINUUM-814
> URL: http://jira.codehaus.org/browse/CONTINUUM-814
> Project: Continuum
> Issue Type: Improvement
> Components: Web interface
> Reporter: Jesse McConnell
> Assigned To: Jesse McConnell
> Fix For: 1.1-alpha-1
>
> Attachments: configuration-interceptor.patch
>
>
> a bit ago I submitted a patch in CONTINUUM-810 that added a ContinuumActionSupport class that leveraged the prepare interceptor to always call a prepare() method checking if the continuum configuration was initialized and if it wasn't to redirect to configuration.
> well shortly after that brett pointed me at how he had solved it in mrm so I figured I would just back out that previous patch and redo it his way..
> that is what this patch does, makes the continuum configuration checking match that of mrm.
> as a byproduct of this the xwork.xml file now has multiple packages and namespaces in it, so I took the oppurtunity to move all of the jsps into src/main/webapp/jsp and the configuration ones into src/main/webapp/jsp/admin
> this is largely cosmetic but it cleans up the -webapp module in ide's and I was in the xwork.xml file anyway.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-814) change ContinuumActionSupport to
ContinuumConfigurationInterceptor
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-814?page=comments#action_72353 ]
Carlos Sanchez commented on CONTINUUM-814:
------------------------------------------
I don't see this approach working, configuration action must need an administrator role and it's a security hole to let it through the first time
Also why move the jsps into /jsp? I understand the admin ones under admin but not the other ones.
> change ContinuumActionSupport to ContinuumConfigurationInterceptor
> ------------------------------------------------------------------
>
> Key: CONTINUUM-814
> URL: http://jira.codehaus.org/browse/CONTINUUM-814
> Project: Continuum
> Issue Type: Improvement
> Components: Web interface
> Reporter: Jesse McConnell
> Attachments: configuration-interceptor.patch
>
>
> a bit ago I submitted a patch in CONTINUUM-810 that added a ContinuumActionSupport class that leveraged the prepare interceptor to always call a prepare() method checking if the continuum configuration was initialized and if it wasn't to redirect to configuration.
> well shortly after that brett pointed me at how he had solved it in mrm so I figured I would just back out that previous patch and redo it his way..
> that is what this patch does, makes the continuum configuration checking match that of mrm.
> as a byproduct of this the xwork.xml file now has multiple packages and namespaces in it, so I took the oppurtunity to move all of the jsps into src/main/webapp/jsp and the configuration ones into src/main/webapp/jsp/admin
> this is largely cosmetic but it cleans up the -webapp module in ide's and I was in the xwork.xml file anyway.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-814) change ContinuumActionSupport to
ContinuumConfigurationInterceptor
Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-814?page=comments#action_72355 ]
Jesse McConnell commented on CONTINUUM-814:
-------------------------------------------
1) yes, that is a problem...how is mrm solving that then? looks like it does the same displaying of configuration if its not setup initially.
2) that was mostly just to get them out of the webapp directory so it displays nicer with in an ide, so you can hide all the jsp's easily...mrm's are all under src/main/webapp/WEB-INF/jsp
> change ContinuumActionSupport to ContinuumConfigurationInterceptor
> ------------------------------------------------------------------
>
> Key: CONTINUUM-814
> URL: http://jira.codehaus.org/browse/CONTINUUM-814
> Project: Continuum
> Issue Type: Improvement
> Components: Web interface
> Reporter: Jesse McConnell
> Attachments: configuration-interceptor.patch
>
>
> a bit ago I submitted a patch in CONTINUUM-810 that added a ContinuumActionSupport class that leveraged the prepare interceptor to always call a prepare() method checking if the continuum configuration was initialized and if it wasn't to redirect to configuration.
> well shortly after that brett pointed me at how he had solved it in mrm so I figured I would just back out that previous patch and redo it his way..
> that is what this patch does, makes the continuum configuration checking match that of mrm.
> as a byproduct of this the xwork.xml file now has multiple packages and namespaces in it, so I took the oppurtunity to move all of the jsps into src/main/webapp/jsp and the configuration ones into src/main/webapp/jsp/admin
> this is largely cosmetic but it cleans up the -webapp module in ide's and I was in the xwork.xml file anyway.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira