You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2003/03/06 22:54:22 UTC
Re: svn commit: rev 5220 - in trunk/subversion: include libsvn_client libsvn_ra_dav libsvn_ra_local libsvn_ra_svn
On Thu, Mar 06, 2003 at 03:01:52PM -0600, cmpilato@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_client/prop_commands.c Thu Mar 6 15:01:40 2003
> @@ -383,7 +383,7 @@
> else if (kind == svn_node_file)
> {
> SVN_ERR (ra_lib->get_file (session, target_relative, revnum,
> - NULL, NULL, &prop_hash));
> + NULL, NULL, &prop_hash, pool));
> }
> else
> {
> @@ -670,7 +670,7 @@
> else if (kind == svn_node_file)
> {
> SVN_ERR (ra_lib->get_file (session, target_relative, revnum,
> - NULL, NULL, &prop_hash));
> + NULL, NULL, &prop_hash, pool));
> }
> else
> {
This whole file is full of iterative and recursive functions which use a
single, mother pool. There isn't a single to call to svn_pool_create()
anywhere in this file.
> Modified: trunk/subversion/libsvn_client/repos_diff.c
> ==============================================================================
> --- trunk/subversion/libsvn_client/repos_diff.c (original)
> +++ trunk/subversion/libsvn_client/repos_diff.c Thu Mar 6 15:01:40 2003
> @@ -287,7 +287,8 @@
> b->path,
> b->edit_baton->revision,
> fstream, NULL,
> - &(b->pristine_props)));
> + &(b->pristine_props),
> + b->pool));
Seems like the comment for this function, get_file_from_ra, is wrong. It
asks about fetching properties, but aren't we doing that above? The
b->pristine_props are the props mentioned, right?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org