You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/28 09:28:36 UTC
Review Request 57131: HiveView 2.0 : After download CSV,
the pop-up persists
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57131/
-----------------------------------------------------------
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20228
https://issues.apache.org/jira/browse/AMBARI-20228
Repository: ambari
Description
-------
- Changed the arguments
- Handle promise for receiving terminating state.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 9fc73a4
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 8f0085c
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js 4b59a13
contrib/views/hive20/src/main/resources/ui/app/services/query.js 3bf10c0
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a
Diff: https://reviews.apache.org/r/57131/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 57131: HiveView 2.0 : After download CSV,
the pop-up persists
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57131/#review167034
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 28, 2017, 9:28 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57131/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 9:28 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20228
> https://issues.apache.org/jira/browse/AMBARI-20228
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Changed the arguments
> - Handle promise for receiving terminating state.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 9fc73a4
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 8f0085c
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js 4b59a13
> contrib/views/hive20/src/main/resources/ui/app/services/query.js 3bf10c0
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a
>
> Diff: https://reviews.apache.org/r/57131/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57131: HiveView 2.0 : After download CSV,
the pop-up persists
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57131/#review167042
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On Feb. 28, 2017, 9:28 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57131/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 9:28 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20228
> https://issues.apache.org/jira/browse/AMBARI-20228
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Changed the arguments
> - Handle promise for receiving terminating state.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 9fc73a4
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 8f0085c
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js 4b59a13
> contrib/views/hive20/src/main/resources/ui/app/services/query.js 3bf10c0
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a
>
> Diff: https://reviews.apache.org/r/57131/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 57131: HiveView 2.0 : After download CSV,
the pop-up persists
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57131/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 11:32 a.m.)
Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20228
https://issues.apache.org/jira/browse/AMBARI-20228
Repository: ambari
Description
-------
- Changed the arguments
- Handle promise for receiving terminating state.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/adapters/job.js 9fc73a4
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 8f0085c
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query/results.js 4b59a13
contrib/views/hive20/src/main/resources/ui/app/services/query.js 3bf10c0
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a
Diff: https://reviews.apache.org/r/57131/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha