Re: [PR] "Partition boost" the group by queries in MSQ for better splits (druid)

["cryptoe (via GitHub)" <gi...@apache.org>]

cryptoe commented on code in PR #15474:
URL: https://github.com/apache/druid/pull/15474#discussion_r1439297956


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/groupby/GroupByPostShuffleFrameProcessor.java:
##########
@@ -306,17 +321,23 @@ private static HavingSpec cloneHavingSpec(final GroupByQuery query)
    * this processor. Kept in sync with the signature generated by {@link GroupByQueryKit}.
    */
   private static VirtualColumns makeVirtualColumnsForFrameWriter(
+      @Nullable final VirtualColumn partitionBoostVirtualColumn,
       final ObjectMapper jsonMapper,
       final GroupByQuery query
   )
   {
+    List<VirtualColumn> virtualColumns = new ArrayList<>();

Review Comment:
   We need a UT for this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org