You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2009/04/17 18:02:14 UTC
[jira] Created: (SLING-928) Include integration tests for Scala
scripting engine
Include integration tests for Scala scripting engine
----------------------------------------------------
Key: SLING-928
URL: https://issues.apache.org/jira/browse/SLING-928
Project: Sling
Issue Type: Improvement
Components: Testing
Reporter: Michael Dürig
Attachments: SLING-928.patch
Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703172#action_12703172 ]
Bertrand Delacretaz commented on SLING-928:
-------------------------------------------
Tests run fine against an already started Sling instance, but not when Sling is started by the cargo maven plugin when running "mvn clean install" in contrib/launchpad/testing.
Steps to reproduce:
1. In contrib/launchpad/testing run
mvn clean integration-test -Dintegration.test.wait=true
this starts Sling with the same environment used for integration testing.
2. Try to look at the OSGi console's script engines page at
http://localhost:8888/org.apache.sling.launchpad.contrib-testing-4-incubator-SNAPSHOT/system/console/scriptengines
This causes the following exception:
java.lang.NullPointerException
at org.apache.sling.scripting.scala.interpreter.BundleFS$BundleEntry$1.getPathAndName(BundleFS.scala:71)
at org.apache.sling.scripting.scala.interpreter.BundleFS$BundleEntry$1.x$1(BundleFS.scala:39)
at org.apache.sling.scripting.scala.interpreter.BundleFS$BundleEntry$1.name(BundleFS.scala:39)
at scala.tools.nsc.symtab.SymbolLoaders$PackageLoader$$anonfun$refresh$1$$anonfun$apply$1.apply(SymbolLoaders.scala:173)
Probably related to the fix of revision 769024, but I'm not sure how to fix that in the scala code.
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928-pom.patch, SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz reassigned SLING-928:
-----------------------------------------
Assignee: Bertrand Delacretaz
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig updated SLING-928:
--------------------------------
Attachment: SLING-928.patch
Simple integration tests for the Scala scripting engine
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Attachments: SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig updated SLING-928:
--------------------------------
Attachment: SLING-928-scala-interpreter.patch
Bundle.getResource() seems to be inconsistent with respect to requiring a trailing slash. The patch tries to circumvent this by trying without slash if getResource() fails with a trailing slash.
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928-pom.patch, SLING-928-scala-interpreter.patch, SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703609#action_12703609 ]
Michael Dürig commented on SLING-928:
-------------------------------------
As discussed before [1] this problem arises because classloaders are used for scripting. I'm going to report this as a separate bug.
[1] http://sling.markmail.org/message/ly3yhlmqufpugjly
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928-pom.patch, SLING-928-scala-interpreter.patch, SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703175#action_12703175 ]
Bertrand Delacretaz commented on SLING-928:
-------------------------------------------
If the console display doesn't fail, this should:
mvn test -Dtest=ScalaScriptingTest -Dhttp.base.path=org.apache.sling.launchpad.contrib-testing-4-incubator-SNAPSHOT -Dwebdav.workspace.path=org.apache.sling.launchpad.contrib-testing-4-incubator-SNAPSHOT
in contrib/launchpad/testing, from another terminal
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928-pom.patch, SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz closed SLING-928.
-------------------------------------
Resolution: Fixed
Patches applied in revision 769356, tests pass in both modes now, thanks!
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928-pom.patch, SLING-928-scala-interpreter.patch, SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703615#action_12703615 ]
Michael Dürig commented on SLING-928:
-------------------------------------
Reported above as SLING-945
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928-pom.patch, SLING-928-scala-interpreter.patch, SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-928) Include integration tests for Scala
scripting engine
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz updated SLING-928:
--------------------------------------
Attachment: SLING-928-pom.patch
pom changes to include the scala scripting engine in contrib/launchpad tests
> Include integration tests for Scala scripting engine
> ----------------------------------------------------
>
> Key: SLING-928
> URL: https://issues.apache.org/jira/browse/SLING-928
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Michael Dürig
> Assignee: Bertrand Delacretaz
> Attachments: SLING-928-pom.patch, SLING-928.patch
>
>
> Include integration tests for the Scala scripting engine in contrib\launchpad\testing
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.