You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mustafasrepo (via GitHub)" <gi...@apache.org> on 2023/04/26 12:40:26 UTC
[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #6124: Feature/stream groupby5
mustafasrepo commented on code in PR #6124:
URL: https://github.com/apache/arrow-datafusion/pull/6124#discussion_r1177820265
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -107,22 +107,6 @@ pub(crate) struct GroupedHashAggregateStream {
indices: [Vec<Range<usize>>; 2],
}
-#[derive(Debug)]
Review Comment:
I have moved functions common for both in `row_hash.rs` and `bounded_aggregate_stream.rs` to the inside `util.rs` file. All the changes in this file, `util.rs` comes because of this reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org