You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/28 19:21:00 UTC
[jira] [Work logged] (BEAM-6947) TestGCSIO.test_last_updated
(gcsio_test.py) fails when the current timezone offset and the timezone
offset on 2nd of Jan 1970 differ
[ https://issues.apache.org/jira/browse/BEAM-6947?focusedWorklogId=320050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320050 ]
ASF GitHub Bot logged work on BEAM-6947:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/19 19:20
Start Date: 28/Sep/19 19:20
Worklog Time Spent: 10m
Work Description: stale[bot] commented on issue #8180: [BEAM-6947] Fix for failing TestGCSIO.test_last_updated (gcsio_test.py) test
URL: https://github.com/apache/beam/pull/8180#issuecomment-536218501
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 320050)
Time Spent: 1h 10m (was: 1h)
> TestGCSIO.test_last_updated (gcsio_test.py) fails when the current timezone offset and the timezone offset on 2nd of Jan 1970 differ
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-6947
> URL: https://issues.apache.org/jira/browse/BEAM-6947
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Csaba Kassai
> Assignee: Csaba Kassai
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The test TestGCSIO.test_last_updated uses timestamp 123456.78 as the last updated timestamp. This timestamp is converted into a naive datetime in the Fakefile class get_metadata method (gcsio_test.py line 72) Then in the GcsIO class last_updated method (gcsio.py ) is converted back to timestamp. But the conversion is incorrect when the the timezone offset is different in 1970 and now. In my case now Singapore is GMT+8 and it was only GMT+7:30 in 1970. So the test fails.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)