You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2024/09/07 02:19:55 UTC

[PR] [SPARK-49424][CONNECT][SQL] Consolidate Encoders.scala [spark]

hvanhovell opened a new pull request, #48021:
URL: https://github.com/apache/spark/pull/48021

   ### What changes were proposed in this pull request?
   This PR moves Encoders.scala to sql/api. It removes the duplicate one in connect.
   
   ### Why are the changes needed?
   We are creating a unified scala interface for Classic and Connect.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Existing tests.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-49424][CONNECT][SQL] Consolidate Encoders.scala [spark]

Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #48021:
URL: https://github.com/apache/spark/pull/48021#issuecomment-2357395613

   Merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-49424][CONNECT][SQL] Consolidate Encoders.scala [spark]

Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #48021:
URL: https://github.com/apache/spark/pull/48021#issuecomment-2339478352

   I need to take a small step back here. It is fairly easy to mix agnostic encoders, and expression encoders, and this causes some issues when we want to combine them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-49424][CONNECT][SQL] Consolidate Encoders.scala [spark]

Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #48021:
URL: https://github.com/apache/spark/pull/48021#discussion_r1747869899


##########
sql/api/src/main/scala/org/apache/spark/sql/Encoders.scala:
##########


Review Comment:
   I actually moved the catalyst one, and removed this one. Git seems to think something else...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-49424][CONNECT][SQL] Consolidate Encoders.scala [spark]

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #48021: [SPARK-49424][CONNECT][SQL] Consolidate Encoders.scala
URL: https://github.com/apache/spark/pull/48021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org