You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/13 09:17:31 UTC
[GitHub] [spark] cloud-fan opened a new pull request #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
cloud-fan opened a new pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Spark introduced CHAR/VARCHAR type for hive compatibility but it only works for hive tables. CHAR/VARCHAR type is never documented and is treated as STRING type for non-Hive tables.
However, this leads to confusing behaviors
```
spark-sql> CREATE TABLE t(a CHAR(3));
spark-sql> INSERT INTO TABLE t SELECT 'a ';
spark-sql> SELECT a, length(a) FROM t;
a 2
```
According to the SQL standard, `CHAR(3)` should guarantee all the values are of length 3. Since `CHAR(3)` is treated as STRING so Spark doesn't guarantee it.
This PR forbids CHAR/VARCHAR type in non-Hive tables as it's not supported correctly.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
avoid confusing/wrong behavior
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
yes, now users can't create/alter non-Hive tables with CHAR/VARCHAR type.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602888698
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602529634
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602529634
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603328072
**[Test build #120263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120263/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601675969
**[Test build #120096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120096/testReport)** for PR 27902 at commit [`33efaac`](https://github.com/apache/spark/commit/33efaac814aaf9a0967877582fb0a6201227f1a4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598669832
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598800427
I support this approach in Apache Spark 3.0.0.
cc @marmbrus and @gatorsmile since this causes many migration failures.
cc @rxin since he is a release manager for 3.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602888706
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120217/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#discussion_r397610314
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +331,19 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
+ throw new AnalysisException(
+ "Cannot use CHAR type in non-Hive-Serde tables, please use STRING type instead.")
+ }
+ }
+
+ def assertNoCharTypeInSchema(schema: StructType): Unit = {
+ schema.foreach { f =>
+ if (f.metadata.contains(HIVE_TYPE_STRING)) {
+ failCharType(CatalystSqlParser.parseRawDataType(f.metadata.getString(HIVE_TYPE_STRING)))
+ }
Review comment:
So we don't need to detect char type in so many cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603134431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24974/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601829482
This PR still bans `VARCHAR`. The failure comes from the following.
```
test("self-join on a partitioned table should not trigger DPP") {
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true",
SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "false",
SQLConf.EXCHANGE_REUSE_ENABLED.key -> "false") {
withTable("fact") {
sql(
s"""
|CREATE TABLE fact (
| col1 varchar(14), col2 bigint, col3 bigint, col4 decimal(18,8), partCol1 varchar(1)
|) USING $tableFormat PARTITIONED BY (partCol1)
""".stripMargin)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601689011
**[Test build #120098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120098/testReport)** for PR 27902 at commit [`32b5023`](https://github.com/apache/spark/commit/32b50234a0abe8dcc5f55bfc34d8c624811f36db).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#discussion_r392324949
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +330,18 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
+ throw new AnalysisException("Cannot use CHAR/VARCHAR type in non-Hive tables.")
Review comment:
Shall we have a directional warning like `Use STRING type instead of CHAR/VARCHAR type in non-Hive tables.`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#discussion_r395443616
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +330,18 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
Review comment:
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598801531
BTW, @cloud-fan . I updated the PR description to give both examples of 2.4.5 and 3.0.0-preview2 to be fair.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602888698
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#discussion_r397610129
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +331,19 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
+ throw new AnalysisException(
+ "Cannot use CHAR type in non-Hive-Serde tables, please use STRING type instead.")
+ }
+ }
+
+ def assertNoCharTypeInSchema(schema: StructType): Unit = {
+ schema.foreach { f =>
+ if (f.metadata.contains(HIVE_TYPE_STRING)) {
+ failCharType(CatalystSqlParser.parseRawDataType(f.metadata.getString(HIVE_TYPE_STRING)))
+ }
Review comment:
Can we just disallow char type at parser? Like throwing exception in `visitColType` when we find it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603064899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120241/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598808533
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#discussion_r397639062
##########
File path: docs/sql-migration-guide.md
##########
@@ -111,6 +111,8 @@ license: |
- Since Spark 3.0, `SHOW CREATE TABLE` will always return Spark DDL, even when the given table is a Hive serde table. For generating Hive DDL, please use `SHOW CREATE TABLE AS SERDE` command instead.
+ - Since Spark 3.0, columns of CHAR type is not allowed in non-Hive-Serde tables, and CREATE/ALTER TABLE commands will fail if CHAR type is detected. Please use STRING type instead. In Spark version 2.4 and earlier, CHAR type is treated as STRING type and the length parameter is simply ignored.
Review comment:
oh, I meant `columns of CHAR type is`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603134422
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601689715
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598808543
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119762/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603134422
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602767270
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24930/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600176191
**[Test build #119940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119940/testReport)** for PR 27902 at commit [`478d164`](https://github.com/apache/spark/commit/478d164c042faef7d307fc48107d6658f6aa6220).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600248688
Hi, @rxin . What is your current opinion on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602436204
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601689723
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24814/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602436204
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601734845
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120096/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602524938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120183/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598669843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24485/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598808543
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119762/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602435634
**[Test build #120183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120183/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598669843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24485/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601676577
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603723045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25040/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-604142540
Thank you, @cloud-fan !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602436211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24896/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#discussion_r397625011
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +331,19 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
+ throw new AnalysisException(
+ "Cannot use CHAR type in non-Hive-Serde tables, please use STRING type instead.")
+ }
+ }
+
+ def assertNoCharTypeInSchema(schema: StructType): Unit = {
+ schema.foreach { f =>
+ if (f.metadata.contains(HIVE_TYPE_STRING)) {
+ failCharType(CatalystSqlParser.parseRawDataType(f.metadata.getString(HIVE_TYPE_STRING)))
+ }
Review comment:
We only forbid CHAR in non-Hive-Serde tables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602713935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603890515
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120328/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600307430
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119940/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603064899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120241/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598730696
**[Test build #119762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119762/testReport)** for PR 27902 at commit [`f2b5825`](https://github.com/apache/spark/commit/f2b5825546f6d94ab322728c5b71fb6fedf0366a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600307426
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598717198
**[Test build #119756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119756/testReport)** for PR 27902 at commit [`d6d57a5`](https://github.com/apache/spark/commit/d6d57a538395fdbcbeced575c44f567e945d72df).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598717466
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603038010
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602528945
**[Test build #120195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120195/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603329583
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602888086
**[Test build #120217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120217/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
* This patch **fails PySpark pip packaging tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603890506
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601717348
**[Test build #120098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120098/testReport)** for PR 27902 at commit [`32b5023`](https://github.com/apache/spark/commit/32b50234a0abe8dcc5f55bfc34d8c624811f36db).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603039854
**[Test build #120241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120241/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603329583
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602767254
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602713935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600307430
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119940/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598648850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119751/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598628886
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601675969
**[Test build #120096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120096/testReport)** for PR 27902 at commit [`33efaac`](https://github.com/apache/spark/commit/33efaac814aaf9a0967877582fb0a6201227f1a4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598648845
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601689723
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24814/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598717466
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602529640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24908/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601717497
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120098/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601717497
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120098/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603038017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24954/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603064892
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598648845
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600176955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24663/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#discussion_r397606686
##########
File path: docs/sql-migration-guide.md
##########
@@ -111,6 +111,8 @@ license: |
- Since Spark 3.0, `SHOW CREATE TABLE` will always return Spark DDL, even when the given table is a Hive serde table. For generating Hive DDL, please use `SHOW CREATE TABLE AS SERDE` command instead.
+ - Since Spark 3.0, columns of CHAR type is not allowed in non-Hive-Serde tables, and CREATE/ALTER TABLE commands will fail if CHAR type is detected. Please use STRING type instead. In Spark version 2.4 and earlier, CHAR type is treated as STRING type and the length parameter is simply ignored.
Review comment:
nit: is -> are
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602766509
**[Test build #120217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120217/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#discussion_r395439533
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +330,18 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
Review comment:
Yea, will update it today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601676589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24812/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598731203
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24491/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602524935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601689715
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598717477
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119756/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598669337
**[Test build #119756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119756/testReport)** for PR 27902 at commit [`d6d57a5`](https://github.com/apache/spark/commit/d6d57a538395fdbcbeced575c44f567e945d72df).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598648779
**[Test build #119751 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119751/testReport)** for PR 27902 at commit [`cdbfea3`](https://github.com/apache/spark/commit/cdbfea36a57d9fcb60cd2d908f58964d4f1c8858).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602524935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600306518
**[Test build #119940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119940/testReport)** for PR 27902 at commit [`478d164`](https://github.com/apache/spark/commit/478d164c042faef7d307fc48107d6658f6aa6220).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601689011
**[Test build #120098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120098/testReport)** for PR 27902 at commit [`32b5023`](https://github.com/apache/spark/commit/32b50234a0abe8dcc5f55bfc34d8c624811f36db).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600307426
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598628274
**[Test build #119751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119751/testReport)** for PR 27902 at commit [`cdbfea3`](https://github.com/apache/spark/commit/cdbfea36a57d9fcb60cd2d908f58964d4f1c8858).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602435634
**[Test build #120183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120183/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602529640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24908/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603038017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24954/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602767270
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24930/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603133876
**[Test build #120263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120263/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603995776
the conflict is caused by that 3.0 doesn't have REPLACE COLUMN. It's easy to fix, I've backported to 3.0 with local test passing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603890506
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602713188
**[Test build #120195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120195/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598730696
**[Test build #119762 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119762/testReport)** for PR 27902 at commit [`f2b5825`](https://github.com/apache/spark/commit/f2b5825546f6d94ab322728c5b71fb6fedf0366a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598808533
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603723033
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603064791
**[Test build #120241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120241/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601734835
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603038010
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602436211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24896/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598628899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24480/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602713944
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120195/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598731200
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598628899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24480/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#discussion_r395437790
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +330,18 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
Review comment:
Shall we revise this PR to ban `CHAR` only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603889204
**[Test build #120328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120328/testReport)** for PR 27902 at commit [`98095bb`](https://github.com/apache/spark/commit/98095bbe8c0aad7eb089e0554c68a095c88c22b3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603132601
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#discussion_r397624892
##########
File path: docs/sql-migration-guide.md
##########
@@ -111,6 +111,8 @@ license: |
- Since Spark 3.0, `SHOW CREATE TABLE` will always return Spark DDL, even when the given table is a Hive serde table. For generating Hive DDL, please use `SHOW CREATE TABLE AS SERDE` command instead.
+ - Since Spark 3.0, columns of CHAR type is not allowed in non-Hive-Serde tables, and CREATE/ALTER TABLE commands will fail if CHAR type is detected. Please use STRING type instead. In Spark version 2.4 and earlier, CHAR type is treated as STRING type and the length parameter is simply ignored.
Review comment:
I think `the length parameter is` is correct in English.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601717484
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603133876
**[Test build #120263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120263/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603064892
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603037661
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603722300
**[Test build #120328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120328/testReport)** for PR 27902 at commit [`98095bb`](https://github.com/apache/spark/commit/98095bbe8c0aad7eb089e0554c68a095c88c22b3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601676589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24812/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598625594
cc @dongjoon-hyun @HeartSaVioR @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603039854
**[Test build #120241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120241/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#discussion_r392330746
##########
File path: docs/sql-migration-guide.md
##########
@@ -334,14 +334,16 @@ license: |
- Since Spark 3.0, `SHOW CREATE TABLE` will always return Spark DDL, even when the given table is a Hive serde table. For generating Hive DDL, please use `SHOW CREATE TABLE AS SERDE` command instead.
- Since Spark 3.0, we upgraded the built-in Hive from 1.2 to 2.3 and it brings following impacts:
-
+
- You may need to set `spark.sql.hive.metastore.version` and `spark.sql.hive.metastore.jars` according to the version of the Hive metastore you want to connect to.
For example: set `spark.sql.hive.metastore.version` to `1.2.1` and `spark.sql.hive.metastore.jars` to `maven` if your Hive metastore version is 1.2.1.
-
+
- You need to migrate your custom SerDes to Hive 2.3 or build your own Spark with `hive-1.2` profile. See HIVE-15167 for more details.
- The decimal string representation can be different between Hive 1.2 and Hive 2.3 when using `TRANSFORM` operator in SQL for script transformation, which depends on hive's behavior. In Hive 1.2, the string representation omits trailing zeroes. But in Hive 2.3, it is always padded to 18 digits with trailing zeroes if necessary.
+ - Since Spark 3.0, columns of CHAR/VARCHAR type are not allowed in non-Hive tables, and CREATE/ALTER TABLE commands will fail if CHAR/VARCHAR type is detected. In Spark version 2.4 and earlier, CHAR/VARCHAR type are treated as STRING type and the length parameter is simply ignored.
Review comment:
BTW, `VARCHAR` is a little different and have more official documents. Could you check them together?
```
$ git grep 'CHAR'
sql-data-sources-jdbc.md: The database column data types to use instead of the defaults, when creating the table. Data type information should be specified in the same format as CREATE TABLE columns syntax (e.g: <code>"name CHAR(64), comments VARCHAR(1024)")</code>. The specified types should be valid spark sql data types. This option applies only to writing.
sql-ref-syntax-aux-describe-table.md: state VARCHAR(20),
sql-ref-syntax-aux-show-columns.md: name VARCHAR(100),
sql-ref-syntax-aux-show-tblproperties.md:CREATE TABLE customer(cust_code INT, name VARCHAR(100), cust_addr STRING)
sql-ref-syntax-dml-insert-into.md: CREATE TABLE students (name VARCHAR(64), address VARCHAR(64), student_id INT)
sql-ref-syntax-dml-load.md: CREATE TABLE test_load (name VARCHAR(64), address VARCHAR(64), student_id INT);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603329595
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120263/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603723045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25040/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602713944
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120195/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598669832
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598808238
**[Test build #119762 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119762/testReport)** for PR 27902 at commit [`f2b5825`](https://github.com/apache/spark/commit/f2b5825546f6d94ab322728c5b71fb6fedf0366a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602528945
**[Test build #120195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120195/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600176943
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598628886
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598669337
**[Test build #119756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119756/testReport)** for PR 27902 at commit [`d6d57a5`](https://github.com/apache/spark/commit/d6d57a538395fdbcbeced575c44f567e945d72df).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598731203
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24491/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601717484
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603329595
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120263/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600176191
**[Test build #119940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119940/testReport)** for PR 27902 at commit [`478d164`](https://github.com/apache/spark/commit/478d164c042faef7d307fc48107d6658f6aa6220).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598717477
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119756/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601734605
**[Test build #120096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120096/testReport)** for PR 27902 at commit [`33efaac`](https://github.com/apache/spark/commit/33efaac814aaf9a0967877582fb0a6201227f1a4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601734845
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120096/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602888706
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120217/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603723033
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598648850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119751/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602526776
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602767254
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602763559
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601734835
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603722300
**[Test build #120328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120328/testReport)** for PR 27902 at commit [`98095bb`](https://github.com/apache/spark/commit/98095bbe8c0aad7eb089e0554c68a095c88c22b3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598628274
**[Test build #119751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119751/testReport)** for PR 27902 at commit [`cdbfea3`](https://github.com/apache/spark/commit/cdbfea36a57d9fcb60cd2d908f58964d4f1c8858).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-598731200
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602524599
**[Test build #120183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120183/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603134431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24974/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-601676577
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600176955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24663/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR/VARCHAR type in non-Hive tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-600176943
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27902: [SPARK-31147][SQL]
forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602766509
**[Test build #120217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120217/testReport)** for PR 27902 at commit [`ba28637`](https://github.com/apache/spark/commit/ba28637297110c54b8724e6c8b0223d0b6a13097).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27902:
[SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27902: [SPARK-31147][SQL] forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-602524938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120183/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603942303
Hi, @cloud-fan . There was a conflict on branch-3.0. Could you make a backporting PR, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27902: [SPARK-31147][SQL]
Forbid CHAR type in non-Hive-Serde tables
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27902: [SPARK-31147][SQL] Forbid CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#issuecomment-603890515
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120328/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org