You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/01 19:56:38 UTC
[GitHub] [iceberg] samredai opened a new pull request #4025: Set black line-length to 130 in tox settings
samredai opened a new pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025
This adds `--line-length` to the black autoformatter and format checker commands in tox.ini
This may cause some open PRs to require rebasing (there's never a good time to change an auto-formatter) but alternatively we can keep this PR open and wait for a dip in open PRs to rebase this PR, run `tox -e format`, and commit the updates.
The first commit is the actual change to the formatter, the second commit is the result of running `tox -e format` on the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025#issuecomment-1028418509
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025#issuecomment-1028416262
88 seems a bit small to me. Since we should do this when it will introduce as few changes as possible, I'll go ahead and merge. Thanks, @samredai!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025#issuecomment-1028417863
Thanks @rdblue. I'm going to open a quick follow-up PR to autoformat again. Looks like a PR was merged after I opened this so wasn't caught here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jun-he commented on pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
jun-he commented on pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025#issuecomment-1028497573
Thanks @samredai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025#issuecomment-1028414146
@rdblue the default for black is 88. From what I've seen, that's usually bumped up to somewhere in the range of 110-130.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai edited a comment on pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
samredai edited a comment on pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025#issuecomment-1028414146
@rdblue the default for black is 88. From what I've seen, that's usually bumped up to somewhere in the range of 110-130. To see some of the side-effects of a low line-length setting, see [this](https://github.com/apache/iceberg/pull/4021#discussion_r796832091) comment on another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4025: Set black line-length to 130 in tox settings
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4025:
URL: https://github.com/apache/iceberg/pull/4025#issuecomment-1028140944
What was the line length without this? Do we need to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org