[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #691: GEODE-8700: Add the ability to change PR

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #691:
URL: https://github.com/apache/geode-native/pull/691#discussion_r521791548



##########
File path: cppcache/include/geode/AttributesMutator.hpp
##########
@@ -190,6 +191,22 @@ class APACHE_GEODE_EXPORT AttributesMutator {
    */
   void setCacheWriter(const std::string& libpath,
                       const std::string& factoryFuncName);
+
+  /** Sets partition resolver writer for region. The previous partition resolver
+   * will be replaced with <code>resolver</code>.
+   * @param resolver PartitionResolver
+   */
+  void setPartitionResolver(std::shared_ptr<PartitionResolver> resolver);
+
+  /** Sets cache writer for region. The previous partition resolver will be
+   * replaced with the one created using the factory function provided in
+   * the given library.
+   * @param library_path path of the library containing partition resolver
+   * factory function.
+   * @param function factory function for creating a partition resolver.
+   */
+  void setPartitionResolver(const std::string& library_path,

Review comment:
       Unless this is explicitly needed by your use case, and I really hope it isn't, let's avoid expanding on this API to load things from arbitrary libraries. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org