You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by cl...@apache.org on 2023/08/14 14:33:44 UTC

[camel-kamelets] branch main updated: Remove no more needed check on reserved keyword for kamelet (#1578)

This is an automated email from the ASF dual-hosted git repository.

claudio4j pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-kamelets.git


The following commit(s) were added to refs/heads/main by this push:
     new e0ed1f8d Remove no more needed check on reserved keyword for kamelet (#1578)
e0ed1f8d is described below

commit e0ed1f8d964f655adb89fca55f0124f44dd6cb46
Author: Aurélien Pupier <ap...@redhat.com>
AuthorDate: Mon Aug 14 16:33:39 2023 +0200

    Remove no more needed check on reserved keyword for kamelet (#1578)
    
    fixes #1577
    
    see also CAMEL-17788
    
    Signed-off-by: Aurélien Pupier <ap...@redhat.com>
---
 script/validator/validator.go | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/script/validator/validator.go b/script/validator/validator.go
index 2fd3c66b..7477330e 100644
--- a/script/validator/validator.go
+++ b/script/validator/validator.go
@@ -28,9 +28,6 @@ import (
 )
 
 var (
-	// Needed until this is fixed: https://issues.apache.org/jira/browse/CAMEL-16788
-	forbiddenParameterNames = []string{"home", "hostname", "language", "lang", "namespace", "path", "podname", "pod-name", "port", "pwd", "shell", "term"}
-
 	paramRegexp = regexp.MustCompile(`{{[?]?([A-Za-z0-9-._]+)(?:[:][^}]*)?}}`)
 )
 
@@ -270,11 +267,6 @@ func verifyParameters(kamelets []KameletInfo) (errors []error) {
 			errors = append(errors, fmt.Errorf("kamelet %q does not contain a definition of type \"object\"", kamelet.Name))
 		}
 		for k, p := range kamelet.Spec.Definition.Properties {
-			for _, f := range forbiddenParameterNames {
-				if strings.EqualFold(k, f) {
-					errors = append(errors, fmt.Errorf("property name %q is using a reserved keyword in kamelet %q", k, kamelet.Name))
-				}
-			}
 			if p.Type == "" {
 				errors = append(errors, fmt.Errorf("property %q in kamelet %q does not contain type", k, kamelet.Name))
 			}