You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Calvin Yu (JIRA)" <ji...@codehaus.org> on 2008/04/16 18:26:55 UTC
[jira] Created: (MASSEMBLY-312) outputFileNameMapping not respected
when the unpack=true
outputFileNameMapping not respected when the unpack=true
--------------------------------------------------------
Key: MASSEMBLY-312
URL: http://jira.codehaus.org/browse/MASSEMBLY-312
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.2-beta-2
Reporter: Calvin Yu
If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
For example:
<dependencySet>
<outputDirectory>some_directory</outputDirectory>
<outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
<unpack>true</unpack>
</dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-312) outputFileNameMapping not respected
when the unpack=true
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MASSEMBLY-312.
--------------------------------
Resolution: Won't Fix
outputFileNameMapping has a default value which will cause all sorts of problems when appended to outputDirectory automatically in cases where unpack == true. The element name: outputFileNameMapping should be a hint at its realm of influence: single files. In other words, when the dependency is NOT unpacked.
The documentation for this element needs to be updated to reflect this, and I'll take care of that now.
> outputFileNameMapping not respected when the unpack=true
> --------------------------------------------------------
>
> Key: MASSEMBLY-312
> URL: http://jira.codehaus.org/browse/MASSEMBLY-312
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Reporter: Calvin Yu
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: massembly-312.txt, massembly312-integration-test.patch
>
>
> If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
> For example:
> <dependencySet>
> <outputDirectory>some_directory</outputDirectory>
> <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
> <unpack>true</unpack>
> </dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-312) outputFileNameMapping not respected
when the unpack=true
Posted by "Petar Tahchiev (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Petar Tahchiev updated MASSEMBLY-312:
-------------------------------------
Attachment: massembly-312.txt
Here is the patch.
> outputFileNameMapping not respected when the unpack=true
> --------------------------------------------------------
>
> Key: MASSEMBLY-312
> URL: http://jira.codehaus.org/browse/MASSEMBLY-312
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Reporter: Calvin Yu
> Attachments: massembly-312.txt
>
>
> If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
> For example:
> <dependencySet>
> <outputDirectory>some_directory</outputDirectory>
> <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
> <unpack>true</unpack>
> </dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-312) outputFileNameMapping not respected
when the unpack=true
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-312:
---------------------------------
Fix Version/s: 2.2-beta-3
> outputFileNameMapping not respected when the unpack=true
> --------------------------------------------------------
>
> Key: MASSEMBLY-312
> URL: http://jira.codehaus.org/browse/MASSEMBLY-312
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Reporter: Calvin Yu
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: massembly-312.txt, massembly312-integration-test.patch
>
>
> If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
> For example:
> <dependencySet>
> <outputDirectory>some_directory</outputDirectory>
> <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
> <unpack>true</unpack>
> </dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-312) outputFileNameMapping not
respected when the unpack=true
Posted by "Michael Heß (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=136151#action_136151 ]
Michael Heß commented on MASSEMBLY-312:
---------------------------------------
We have this issue as well.
Calvin, our current workaround is to just use outputDirectory, e.g. for the example given above, we would use:
<outputDirectory>some_directory/${artifact.artifactId}.${artifact.extension}</outputDirectory>
and leave out the outputFileNameMapping . Maybe this helps in your case as well.
> outputFileNameMapping not respected when the unpack=true
> --------------------------------------------------------
>
> Key: MASSEMBLY-312
> URL: http://jira.codehaus.org/browse/MASSEMBLY-312
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Reporter: Calvin Yu
>
> If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
> For example:
> <dependencySet>
> <outputDirectory>some_directory</outputDirectory>
> <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
> <unpack>true</unpack>
> </dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-312) outputFileNameMapping not
respected when the unpack=true
Posted by "Petar Tahchiev (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=146816#action_146816 ]
Petar Tahchiev commented on MASSEMBLY-312:
------------------------------------------
Not sure if this is a bug, since the outputFileNameMapping clearly denotes that it is supposed for file-names, not directory names. But if the maven team decides to change this behavior I have attached a patch that can be used. Once again, IMHO, this is not a bug itself, but instead misuse of the outputFileNameMapping attribute.
HTH, Petar.
> outputFileNameMapping not respected when the unpack=true
> --------------------------------------------------------
>
> Key: MASSEMBLY-312
> URL: http://jira.codehaus.org/browse/MASSEMBLY-312
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Reporter: Calvin Yu
>
> If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
> For example:
> <dependencySet>
> <outputDirectory>some_directory</outputDirectory>
> <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
> <unpack>true</unpack>
> </dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-312) outputFileNameMapping not respected
when the unpack=true
Posted by "Petar Tahchiev (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Petar Tahchiev updated MASSEMBLY-312:
-------------------------------------
Attachment: massembly312-integration-test.patch
Here is an integration test for this issue.
> outputFileNameMapping not respected when the unpack=true
> --------------------------------------------------------
>
> Key: MASSEMBLY-312
> URL: http://jira.codehaus.org/browse/MASSEMBLY-312
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Reporter: Calvin Yu
> Attachments: massembly-312.txt, massembly312-integration-test.patch
>
>
> If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
> For example:
> <dependencySet>
> <outputDirectory>some_directory</outputDirectory>
> <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
> <unpack>true</unpack>
> </dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (MASSEMBLY-312) outputFileNameMapping not
respected when the unpack=true
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on MASSEMBLY-312 started by John Casey.
> outputFileNameMapping not respected when the unpack=true
> --------------------------------------------------------
>
> Key: MASSEMBLY-312
> URL: http://jira.codehaus.org/browse/MASSEMBLY-312
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Reporter: Calvin Yu
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: massembly-312.txt, massembly312-integration-test.patch
>
>
> If I configure a dependencySet to unpack = true, the outputFileNameMapping is not respected, and instead the artifact is decompressed into the output directory. Looking at the code, this looks like it'll affect moduleSets as well.
> For example:
> <dependencySet>
> <outputDirectory>some_directory</outputDirectory>
> <outputFileNameMapping>${artifact.artifactId}.${artifact.extension}</outputFileNameMapping>
> <unpack>true</unpack>
> </dependencySet>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira