You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/11 12:07:14 UTC
[GitHub] [arrow-rs] jackwener opened a new pull request #1428: remove redundant if/clamp_min/abs
jackwener opened a new pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428
# Which issue does this PR close?
Closes #1427.
# Rationale for this change
None
# What changes are included in this PR?
There are some redundant code for control flow
`if` is control flow will break the cpu pipeline, we should reduce the useless `if`.
`bbs()` should remove, and replace with code in the if
`clamp_min` is useless
# Are there any user-facing changes?
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1428: remove redundant if/clamp_min/abs
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener commented on pull request #1428: remove redundant if/clamp_min/abs
Posted by GitBox <gi...@apache.org>.
jackwener commented on pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428#issuecomment-1066111964
@jameslamb PTAL
It's a small change, remove some redundant function-call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener edited a comment on pull request #1428: remove redundant if/clamp_min/abs
Posted by GitBox <gi...@apache.org>.
jackwener edited a comment on pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428#issuecomment-1066111964
@jameslamb PTAL❤
It's a small change, remove some redundant function-call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener edited a comment on pull request #1428: remove redundant if/clamp_min/abs
Posted by GitBox <gi...@apache.org>.
jackwener edited a comment on pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428#issuecomment-1066111964
@jameslamb @Jimexist PTAL❤
It's a small change, remove some redundant function-call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on pull request #1428: remove redundant if/clamp_min/abs
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428#issuecomment-1066495718
I think it is a good refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener commented on pull request #1428: remove redundant if/clamp_min/abs
Posted by GitBox <gi...@apache.org>.
jackwener commented on pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428#issuecomment-1069110605
Yes, It don't have big performance impact because key performance overhead is in `concat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1428: remove redundant if/clamp_min/abs
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1428:
URL: https://github.com/apache/arrow-rs/pull/1428#issuecomment-1070447120
Thanks again @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org