You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/07/02 16:30:03 UTC
[GitHub] [ratis] codings-dan opened a new pull request, #669: Add notify server step sown event to inform
codings-dan opened a new pull request, #669:
URL: https://github.com/apache/ratis/pull/669
see https://issues.apache.org/jira/browse/RATIS-1611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on a diff in pull request #669: Add notify server step sown event to inform
Posted by GitBox <gi...@apache.org>.
codings-dan commented on code in PR #669:
URL: https://github.com/apache/ratis/pull/669#discussion_r912577313
##########
ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java:
##########
@@ -192,6 +192,11 @@ default void notifyLogFailed(Throwable cause, LogEntryProto failedEntry) {}
* completely done. Could trigger the cleanup of snapshots.
*/
default void notifySnapshotInstalled(InstallSnapshotResult result, long snapshotIndex) {}
+
+ /**
+ * Notify the {@link StateMachine} that a raft server has step down.
+ */
+ default void notifyServerStepDown() {}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #669: Add notify server step sown event to inform
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #669:
URL: https://github.com/apache/ratis/pull/669#discussion_r912389894
##########
ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java:
##########
@@ -192,6 +192,11 @@ default void notifyLogFailed(Throwable cause, LogEntryProto failedEntry) {}
* completely done. Could trigger the cleanup of snapshots.
*/
default void notifySnapshotInstalled(InstallSnapshotResult result, long snapshotIndex) {}
+
+ /**
+ * Notify the {@link StateMachine} that a raft server has step down.
+ */
+ default void notifyServerStepDown() {}
Review Comment:
Let's call it notifyServerShutdown and pass a RoleInfoProto parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #669: RATIS-1611. Add notify server step sown event to inform
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #669:
URL: https://github.com/apache/ratis/pull/669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #669: Add notify server step sown event to inform
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #669:
URL: https://github.com/apache/ratis/pull/669#issuecomment-1173257781
@szetszwo PTAL again, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] codings-dan commented on pull request #669: Add notify server step sown event to inform
Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #669:
URL: https://github.com/apache/ratis/pull/669#issuecomment-1172924531
@szetszwo Can you help review this pull request, thank you in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org