[GitHub] [druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r369485581
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/segment/SegmentUtils.java
 ##########
 @@ -78,16 +78,14 @@ public static int getVersionFromDir(File inDir) throws IOException
   }
 
   /**
-   * Returns a String with identifiers of "segments" comma-separated. Useful for log messages. Not useful for anything
-   * else, because this doesn't take special effort to escape commas that occur in identifiers (not common, but could
-   * potentially occur in a datasource name).
+   * Returns an object whose toString() returns a String with identifiers of the given segments, comma-separated. Useful
+   * for log messages. Not useful for anything else, because this doesn't take special effort to escape commas that
+   * occur in identifiers (not common, but could potentially occur in a datasource name).
    */
-  public static String commaSeparateIdentifiers(final Collection<DataSegment> segments)
+  public static Object commaSeparatedIdentifiers(final Collection<DataSegment> segments)
 
 Review comment:
   The purpose is to make this method unusable for anything except logging. To obtain a collection of SegmentIds, people should usually use Stream API to create a non-lazy collection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org