You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Akins <ba...@web.turner.com> on 2005/09/26 18:09:14 UTC
[PATCH] ProxyVia Full honor ServerTokens
Paul Querna wrote:
> Brian Akins wrote:
>
>> It seems no matter what the setting of ServerTokens, mod_proxy uses
>> something like this when ProxyVia is set to Full:
>>
>> Via: 1.1 i.cnn.net (Apache/2.1.8)
>>
>> Should this honor ServerTokens?
>>
>>
>
> Yes.
>
--- mod_proxy_http.c.orig 2005-09-26 11:43:45.893872108 -0400
+++ mod_proxy_http.c 2005-09-26 12:06:48.390005516 -0400
@@ -641,7 +641,7 @@
HTTP_VERSION_MAJOR(r->proto_num),
HTTP_VERSION_MINOR(r->proto_num),
server_name, server_portstr,
- AP_SERVER_BASEVERSION)
+ ap_get_server_version())
: apr_psprintf(p, "%d.%d %s%s",
HTTP_VERSION_MAJOR(r->proto_num),
HTTP_VERSION_MINOR(r->proto_num),
@@ -1296,7 +1296,7 @@
HTTP_VERSION_MINOR(r->proto_num),
server_name,
server_portstr,
- AP_SERVER_BASEVERSION)
+ ap_get_server_version())
: apr_psprintf(p, "%d.%d %s%s",
HTTP_VERSION_MAJOR(r->proto_num),
HTTP_VERSION_MINOR(r->proto_num),
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
Re: [PATCH] ProxyVia Full honor ServerTokens
Posted by Aaron Bannert <aa...@clove.org>.
Makes sense, +1 in concept.
-a
On Oct 28, 2005, at 6:40 AM, Brian Akins wrote:
> Can we get a vote on this?
>
>> --- mod_proxy_http.c.orig 2005-09-26 11:43:45.893872108 -0400
>> +++ mod_proxy_http.c 2005-09-26 12:06:48.390005516 -0400
>> @@ -641,7 +641,7 @@
>> HTTP_VERSION_MAJOR(r-
>> >proto_num),
>> HTTP_VERSION_MINOR(r-
>> >proto_num),
>> server_name, server_portstr,
>> - AP_SERVER_BASEVERSION)
>> + ap_get_server_version())
>> : apr_psprintf(p, "%d.%d %s%s",
>> HTTP_VERSION_MAJOR(r-
>> >proto_num),
>> HTTP_VERSION_MINOR(r-
>> >proto_num),
>> @@ -1296,7 +1296,7 @@
>> HTTP_VERSION_MINOR(r->proto_num),
>> server_name,
>> server_portstr,
>> - AP_SERVER_BASEVERSION)
>> + ap_get_server_version())
>> : apr_psprintf(p, "%d.%d %s%s",
>> HTTP_VERSION_MAJOR(r->proto_num),
>> HTTP_VERSION_MINOR(r->proto_num),
>>
>
>
> --
> Brian Akins
> Lead Systems Engineer
> CNN Internet Technologies
>
>
Re: [PATCH] ProxyVia Full honor ServerTokens
Posted by Brian Akins <ba...@web.turner.com>.
Can we get a vote on this?
Brian Akins wrote:
> Paul Querna wrote:
>
>> Brian Akins wrote:
>>
>>> It seems no matter what the setting of ServerTokens, mod_proxy uses
>>> something like this when ProxyVia is set to Full:
>>>
>>> Via: 1.1 i.cnn.net (Apache/2.1.8)
>>>
>>> Should this honor ServerTokens?
>>>
>>>
>>
>> Yes.
>>
>
>
> --- mod_proxy_http.c.orig 2005-09-26 11:43:45.893872108 -0400
> +++ mod_proxy_http.c 2005-09-26 12:06:48.390005516 -0400
> @@ -641,7 +641,7 @@
> HTTP_VERSION_MAJOR(r->proto_num),
> HTTP_VERSION_MINOR(r->proto_num),
> server_name, server_portstr,
> - AP_SERVER_BASEVERSION)
> + ap_get_server_version())
> : apr_psprintf(p, "%d.%d %s%s",
> HTTP_VERSION_MAJOR(r->proto_num),
> HTTP_VERSION_MINOR(r->proto_num),
> @@ -1296,7 +1296,7 @@
>
> HTTP_VERSION_MINOR(r->proto_num),
> server_name,
> server_portstr,
> - AP_SERVER_BASEVERSION)
> + ap_get_server_version())
> : apr_psprintf(p, "%d.%d %s%s",
>
> HTTP_VERSION_MAJOR(r->proto_num),
>
> HTTP_VERSION_MINOR(r->proto_num),
>
>
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
Re: [PATCH] ProxyVia Full honor ServerTokens
Posted by Brian Akins <ba...@web.turner.com>.
Still no vote on this. It's just annoying, so I'm just running
ProxyVia Off currently. Id' like to turn it on.
Brian Akins wrote:
> Paul Querna wrote:
>
>> Brian Akins wrote:
>>
>>> It seems no matter what the setting of ServerTokens, mod_proxy uses
>>> something like this when ProxyVia is set to Full:
>>>
>>> Via: 1.1 i.cnn.net (Apache/2.1.8)
>>>
>>> Should this honor ServerTokens?
>>>
>>>
>>
>> Yes.
>>
>
>
> --- mod_proxy_http.c.orig 2005-09-26 11:43:45.893872108 -0400
> +++ mod_proxy_http.c 2005-09-26 12:06:48.390005516 -0400
> @@ -641,7 +641,7 @@
> HTTP_VERSION_MAJOR(r->proto_num),
> HTTP_VERSION_MINOR(r->proto_num),
> server_name, server_portstr,
> - AP_SERVER_BASEVERSION)
> + ap_get_server_version())
> : apr_psprintf(p, "%d.%d %s%s",
> HTTP_VERSION_MAJOR(r->proto_num),
> HTTP_VERSION_MINOR(r->proto_num),
> @@ -1296,7 +1296,7 @@
>
> HTTP_VERSION_MINOR(r->proto_num),
> server_name,
> server_portstr,
> - AP_SERVER_BASEVERSION)
> + ap_get_server_version())
> : apr_psprintf(p, "%d.%d %s%s",
>
> HTTP_VERSION_MAJOR(r->proto_num),
>
> HTTP_VERSION_MINOR(r->proto_num),
>
>
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies