You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/09/28 13:53:05 UTC

[GitHub] [maven] gnodet commented on a diff in pull request #1270: [MNG-7899] Various memory usage improvements 5

gnodet commented on code in PR #1270:
URL: https://github.com/apache/maven/pull/1270#discussion_r1340193426


##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -495,19 +495,6 @@ void logging(CliRequest cliRequest) {
         cliRequest.quiet = !cliRequest.verbose && commandLine.hasOption(CLIManager.QUIET);
         cliRequest.showErrors = cliRequest.verbose || commandLine.hasOption(CLIManager.ERRORS);
 
-        slf4jLoggerFactory = LoggerFactory.getILoggerFactory();

Review Comment:
   Moving this code block is necessary because Jansi needs to be initialised before the execution of this block when `MessageUtils.setColorEnabled` is called ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org