[GitHub] [incubator-apisix] moonming commented on a change in pull request #1845: remove not used plugin heartbeat.lua

[GitBox <gi...@apache.org>]

moonming commented on a change in pull request #1845:
URL: https://github.com/apache/incubator-apisix/pull/1845#discussion_r454917841



##########
File path: Makefile
##########
@@ -176,7 +176,7 @@ install: default
 
 ### test:             Run the test case
 test:
-	prove -I../test-nginx/lib -I./ -r -s t/
+	TEST_NGINX_BINARY=`which openresty` prove -I../test-nginx/lib -I../test-nginx/inc -I./ -r -s t/

Review comment:
       why change this line? which is non-related with heartbeat plugin.

##########
File path: t/lib/server.lua
##########
@@ -112,10 +112,6 @@ function _M.mock_skywalking_v2_instance_register()
     ngx.say(json_encode(ret))
 end
 
-function _M.mock_skywalking_v2_instance_heartbeat()
-    ngx.say('skywalking heartbeat ok')
-end
-

Review comment:
       these codes should not remove.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org