[GitHub] [brooklyn-server] jcabrerizo commented on a change in pull request #1204: Introduce lineId for log entries

[GitBox <gi...@apache.org>]

jcabrerizo commented on a change in pull request #1204:
URL: https://github.com/apache/brooklyn-server/pull/1204#discussion_r672129002



##########
File path: core/src/main/java/org/apache/brooklyn/util/core/logbook/file/FileLogStore.java
##########
@@ -69,23 +70,28 @@
     public final static ConfigKey<String> LOGBOOK_LOG_STORE_DATEFORMAT = ConfigKeys.newStringConfigKey(
             BASE_NAME_FILE_LOG_STORE + ".dateFormat", "Date format", "yyyy-MM-dd'T'HH:mm:ss,SSS");
 
+    public final static TimeZone UTC_TIMEZONE = TimeZone.getTimeZone("UTC");
+
     private final String filePath;
     private final Path path;
     private final String logLinePattern;
-    private final String logDateFormat;
+    private final DateFormat dateFormat;
+
 
     @VisibleForTesting
     public FileLogStore() {
         this.path = null;
         this.filePath = "";
         this.logLinePattern = LOGBOOK_LOG_STORE_REGEX.getDefaultValue();
-        this.logDateFormat = LOGBOOK_LOG_STORE_DATEFORMAT.getDefaultValue();
+        dateFormat = new SimpleDateFormat(LOGBOOK_LOG_STORE_DATEFORMAT.getDefaultValue());

Review comment:
       I'd add `this.` to dateFormat to keep it consistent 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org