You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2016/03/20 15:03:18 UTC
seteventfired too early?
Hi guys,
any reason to consider the event fired before firing it there:
https://github.com/apache/openwebbeans/blob/5197d2ce7f270e7089184b942d4c8e1c8ddc53b6/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java#L670
?
Romain Manni-Bucau
@rmannibucau | Blog | Github | LinkedIn | Tomitriber
Re: seteventfired too early?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
finally pushed a test about it
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2016-04-17 14:23 GMT+02:00 Gerhard Petracek <gp...@apache.org>:
> since it happened randomly, i tested it multiple times.
> so far it looks fine - thx!
>
> regards,
> gerhard
>
>
>
> 2016-04-14 19:57 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
>
> > pushed a change, if anyone has time to validate it. Hope to be able to
> work
> > on a test next week but any help is welcomed
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com> | JavaEE Factory
> > <https://javaeefactory-rmannibucau.rhcloud.com>
> >
> > 2016-04-14 18:10 GMT+02:00 Gerhard Petracek <gp...@apache.org>:
> >
> > > +1 for changing it (otherwise we break ds-partial-beans)
> > >
> > > regards,
> > > gerhard
> > >
> > >
> > >
> > > 2016-03-20 15:03 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> > >
> > > > Hi guys,
> > > >
> > > > any reason to consider the event fired before firing it there:
> > > >
> > > >
> > >
> >
> https://github.com/apache/openwebbeans/blob/5197d2ce7f270e7089184b942d4c8e1c8ddc53b6/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java#L670
> > > > ?
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau | Blog | Github | LinkedIn | Tomitriber
> > > >
> > >
> >
>
Re: seteventfired too early?
Posted by Gerhard Petracek <gp...@apache.org>.
since it happened randomly, i tested it multiple times.
so far it looks fine - thx!
regards,
gerhard
2016-04-14 19:57 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> pushed a change, if anyone has time to validate it. Hope to be able to work
> on a test next week but any help is welcomed
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>
> 2016-04-14 18:10 GMT+02:00 Gerhard Petracek <gp...@apache.org>:
>
> > +1 for changing it (otherwise we break ds-partial-beans)
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2016-03-20 15:03 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> >
> > > Hi guys,
> > >
> > > any reason to consider the event fired before firing it there:
> > >
> > >
> >
> https://github.com/apache/openwebbeans/blob/5197d2ce7f270e7089184b942d4c8e1c8ddc53b6/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java#L670
> > > ?
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau | Blog | Github | LinkedIn | Tomitriber
> > >
> >
>
Re: seteventfired too early?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
pushed a change, if anyone has time to validate it. Hope to be able to work
on a test next week but any help is welcomed
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2016-04-14 18:10 GMT+02:00 Gerhard Petracek <gp...@apache.org>:
> +1 for changing it (otherwise we break ds-partial-beans)
>
> regards,
> gerhard
>
>
>
> 2016-03-20 15:03 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
>
> > Hi guys,
> >
> > any reason to consider the event fired before firing it there:
> >
> >
> https://github.com/apache/openwebbeans/blob/5197d2ce7f270e7089184b942d4c8e1c8ddc53b6/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java#L670
> > ?
> >
> > Romain Manni-Bucau
> > @rmannibucau | Blog | Github | LinkedIn | Tomitriber
> >
>
Re: seteventfired too early?
Posted by Gerhard Petracek <gp...@apache.org>.
+1 for changing it (otherwise we break ds-partial-beans)
regards,
gerhard
2016-03-20 15:03 GMT+01:00 Romain Manni-Bucau <rm...@gmail.com>:
> Hi guys,
>
> any reason to consider the event fired before firing it there:
>
> https://github.com/apache/openwebbeans/blob/5197d2ce7f270e7089184b942d4c8e1c8ddc53b6/webbeans-impl/src/main/java/org/apache/webbeans/config/BeansDeployer.java#L670
> ?
>
> Romain Manni-Bucau
> @rmannibucau | Blog | Github | LinkedIn | Tomitriber
>