You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "David Bertoni (JIRA)" <xa...@xml.apache.org> on 2005/06/30 08:29:57 UTC

[jira] Created: (XALANC-530) Serializers filter attributes unnecessarily

Serializers filter attributes unnecessarily
-------------------------------------------

         Key: XALANC-530
         URL: http://issues.apache.org/jira/browse/XALANC-530
     Project: XalanC
        Type: Bug
  Components: XalanC  
    Versions: CurrentCVS    
    Reporter: David Bertoni
 Assigned to: David Bertoni 


There is code in many of the serializers to filter out the namespace binding for the xml prefix which is added to the document element when the source tree is constructed.  This is now being filter in XSLTEngineImpl::addResultAttribute(), so this extra filtering is unnecessary, and a performance issue.

A patch is forthcoming.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Updated: (XALANC-530) Serializers filter attributes unnecessarily

Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANC-530?page=all ]

David Bertoni updated XALANC-530:
---------------------------------

    Attachment: patch.txt

Patch is ready for review.

> Serializers filter attributes unnecessarily
> -------------------------------------------
>
>          Key: XALANC-530
>          URL: http://issues.apache.org/jira/browse/XALANC-530
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>     Reporter: David Bertoni
>     Assignee: David Bertoni
>  Attachments: patch.txt
>
> There is code in many of the serializers to filter out the namespace binding for the xml prefix which is added to the document element when the source tree is constructed.  This is now being filter in XSLTEngineImpl::addResultAttribute(), so this extra filtering is unnecessary, and a performance issue.
> A patch is forthcoming.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Resolved: (XALANC-530) Serializers filter attributes unnecessarily

Posted by "David Bertoni (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANC-530?page=all ]
     
David Bertoni resolved XALANC-530:
----------------------------------

    Fix Version: CurrentCVS
     Resolution: Fixed

Patch is applied.

> Serializers filter attributes unnecessarily
> -------------------------------------------
>
>          Key: XALANC-530
>          URL: http://issues.apache.org/jira/browse/XALANC-530
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>     Reporter: David Bertoni
>     Assignee: David Bertoni
>      Fix For: CurrentCVS
>  Attachments: patch.txt
>
> There is code in many of the serializers to filter out the namespace binding for the xml prefix which is added to the document element when the source tree is constructed.  This is now being filter in XSLTEngineImpl::addResultAttribute(), so this extra filtering is unnecessary, and a performance issue.
> A patch is forthcoming.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Commented: (XALANC-530) Serializers filter attributes unnecessarily

Posted by "Dmitry Hayes (JIRA)" <xa...@xml.apache.org>.
    [ http://issues.apache.org/jira/browse/XALANC-530?page=comments#action_12314809 ] 

Dmitry Hayes commented on XALANC-530:
-------------------------------------

I was always suspicious about that  "$$$ ToDo" mark in the code . The patch seems to be correct. Thanks!

> Serializers filter attributes unnecessarily
> -------------------------------------------
>
>          Key: XALANC-530
>          URL: http://issues.apache.org/jira/browse/XALANC-530
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>     Reporter: David Bertoni
>     Assignee: David Bertoni
>  Attachments: patch.txt
>
> There is code in many of the serializers to filter out the namespace binding for the xml prefix which is added to the document element when the source tree is constructed.  This is now being filter in XSLTEngineImpl::addResultAttribute(), so this extra filtering is unnecessary, and a performance issue.
> A patch is forthcoming.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org