You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2016/04/19 22:16:14 UTC
Review Request 46403: Blueprint processor does not replace
"localhost" in "xasecure.audit.destination.hdfs.dir" property.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46403/
-----------------------------------------------------------
Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Robert Nettleton, and Sandor Magyari.
Bugs: AMBARI-15978
https://issues.apache.org/jira/browse/AMBARI-15978
Repository: ambari
Description
-------
Add Blueprint processor property updaters for `xasecure.audit.destination.hdfs.dir` property for all configuration types where this propery appears. This property is used when Ranger is configured to store it's audit logs in HDFS
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5e8241b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java dd26c75
Diff: https://reviews.apache.org/r/46403/diff/
Testing
-------
Created cluster using Blueprint having Ranger configured to store its audit logs in HDFS.
Unit test results:
ViewRegistry.readViewArchive(/var/folders/l6/1zwz7jr910gd0kpykwdr_m9w0000gn/T/test_dir/file.jar): expected: 1, actual: 0
Tests run: 4226, Failures: 1, Errors: 0, Skipped: 32
The failing `ViewRegistry.readViewArchive` is unrelated to this change.
Thanks,
Sebastian Toader
Re: Review Request 46403: Blueprint processor does not replace
"localhost" in "xasecure.audit.destination.hdfs.dir" property.
Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46403/#review129715
-----------------------------------------------------------
Ship it!
Ship It!
- Balázs Bence Sári
On April 19, 2016, 8:16 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46403/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 8:16 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Robert Nettleton, and Sandor Magyari.
>
>
> Bugs: AMBARI-15978
> https://issues.apache.org/jira/browse/AMBARI-15978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Blueprint processor property updaters for `xasecure.audit.destination.hdfs.dir` property for all configuration types where this propery appears. This property is used when Ranger is configured to store it's audit logs in HDFS
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5e8241b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java dd26c75
>
> Diff: https://reviews.apache.org/r/46403/diff/
>
>
> Testing
> -------
>
> Created cluster using Blueprint having Ranger configured to store its audit logs in HDFS.
>
> Unit test results:
> ViewRegistry.readViewArchive(/var/folders/l6/1zwz7jr910gd0kpykwdr_m9w0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4226, Failures: 1, Errors: 0, Skipped: 32
>
>
> The failing `ViewRegistry.readViewArchive` is unrelated to this change.
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 46403: Blueprint processor does not replace
"localhost" in "xasecure.audit.destination.hdfs.dir" property.
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46403/#review129619
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 19, 2016, 8:16 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46403/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 8:16 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Robert Nettleton, and Sandor Magyari.
>
>
> Bugs: AMBARI-15978
> https://issues.apache.org/jira/browse/AMBARI-15978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Blueprint processor property updaters for `xasecure.audit.destination.hdfs.dir` property for all configuration types where this propery appears. This property is used when Ranger is configured to store it's audit logs in HDFS
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5e8241b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java dd26c75
>
> Diff: https://reviews.apache.org/r/46403/diff/
>
>
> Testing
> -------
>
> Created cluster using Blueprint having Ranger configured to store its audit logs in HDFS.
>
> Unit test results:
> ViewRegistry.readViewArchive(/var/folders/l6/1zwz7jr910gd0kpykwdr_m9w0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4226, Failures: 1, Errors: 0, Skipped: 32
>
>
> The failing `ViewRegistry.readViewArchive` is unrelated to this change.
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 46403: Blueprint processor does not replace
"localhost" in "xasecure.audit.destination.hdfs.dir" property.
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46403/#review129713
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On April 19, 2016, 8:16 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46403/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 8:16 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Robert Nettleton, and Sandor Magyari.
>
>
> Bugs: AMBARI-15978
> https://issues.apache.org/jira/browse/AMBARI-15978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Blueprint processor property updaters for `xasecure.audit.destination.hdfs.dir` property for all configuration types where this propery appears. This property is used when Ranger is configured to store it's audit logs in HDFS
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5e8241b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java dd26c75
>
> Diff: https://reviews.apache.org/r/46403/diff/
>
>
> Testing
> -------
>
> Created cluster using Blueprint having Ranger configured to store its audit logs in HDFS.
>
> Unit test results:
> ViewRegistry.readViewArchive(/var/folders/l6/1zwz7jr910gd0kpykwdr_m9w0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4226, Failures: 1, Errors: 0, Skipped: 32
>
>
> The failing `ViewRegistry.readViewArchive` is unrelated to this change.
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 46403: Blueprint processor does not replace
"localhost" in "xasecure.audit.destination.hdfs.dir" property.
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46403/#review129707
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Gergely
On ápr. 19, 2016, 8:16 du, Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46403/
> -----------------------------------------------------------
>
> (Updated ápr. 19, 2016, 8:16 du)
>
>
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Robert Nettleton, and Sandor Magyari.
>
>
> Bugs: AMBARI-15978
> https://issues.apache.org/jira/browse/AMBARI-15978
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add Blueprint processor property updaters for `xasecure.audit.destination.hdfs.dir` property for all configuration types where this propery appears. This property is used when Ranger is configured to store it's audit logs in HDFS
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 5e8241b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java dd26c75
>
> Diff: https://reviews.apache.org/r/46403/diff/
>
>
> Testing
> -------
>
> Created cluster using Blueprint having Ranger configured to store its audit logs in HDFS.
>
> Unit test results:
> ViewRegistry.readViewArchive(/var/folders/l6/1zwz7jr910gd0kpykwdr_m9w0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4226, Failures: 1, Errors: 0, Skipped: 32
>
>
> The failing `ViewRegistry.readViewArchive` is unrelated to this change.
>
>
> Thanks,
>
> Sebastian Toader
>
>