You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "YiwenWu (via GitHub)" <gi...@apache.org> on 2024/09/12 13:40:31 UTC
[PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
YiwenWu opened a new pull request, #3963:
URL: https://github.com/apache/calcite/pull/3963
…all covered with cast
https://issues.apache.org/jira/browse/CALCITE-6374
Ensure that the `name` field of `MutableMeasure` is not empty. If `name` is empty, an alias will be automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3963:
URL: https://github.com/apache/calcite/pull/3963#issuecomment-2367129744
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3963) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3963&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3963&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3963&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3963&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3963&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3963)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #3963:
URL: https://github.com/apache/calcite/pull/3963#discussion_r1756908723
##########
core/src/test/java/org/apache/calcite/materialize/LatticeSuggesterTest.java:
##########
@@ -721,6 +721,36 @@ private void checkDerivedColumn(Lattice lattice, List<String> tables,
checkFoodmartSimpleJoin(CalciteAssert.SchemaSpec.FAKE_FOODMART);
}
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6374">[CALCITE-6374]
+ * LatticeSuggester throw NullPointerException when agg call covered with cast </a>. */
+ @Test void testCastExpression() throws Exception {
Review Comment:
Maybe the name testCastExpression is not clear enough. Is there a clearer way to use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
Posted by "YiwenWu (via GitHub)" <gi...@apache.org>.
YiwenWu commented on code in PR #3963:
URL: https://github.com/apache/calcite/pull/3963#discussion_r1758008716
##########
core/src/test/java/org/apache/calcite/materialize/LatticeSuggesterTest.java:
##########
@@ -721,6 +721,36 @@ private void checkDerivedColumn(Lattice lattice, List<String> tables,
checkFoodmartSimpleJoin(CalciteAssert.SchemaSpec.FAKE_FOODMART);
}
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6374">[CALCITE-6374]
+ * LatticeSuggester throw NullPointerException when agg call covered with cast </a>. */
+ @Test void testCastExpression() throws Exception {
Review Comment:
Adjusted test method name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3963:
URL: https://github.com/apache/calcite/pull/3963#issuecomment-2347895360
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3963) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3963&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3963&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3963&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3963&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3963&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3963)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
Posted by "macroguo-ghy (via GitHub)" <gi...@apache.org>.
macroguo-ghy merged PR #3963:
URL: https://github.com/apache/calcite/pull/3963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
Posted by "YiwenWu (via GitHub)" <gi...@apache.org>.
YiwenWu commented on PR #3963:
URL: https://github.com/apache/calcite/pull/3963#issuecomment-2367122756
@macroguo-ghy thank you for the review, I have squashed commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6374] LatticeSuggester throw NullPointerException when agg c… [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3963:
URL: https://github.com/apache/calcite/pull/3963#issuecomment-2347905913
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3963) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3963&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3963&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3963&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3963&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3963&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3963)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org