You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "Cyrill (via GitHub)" <gi...@apache.org> on 2023/09/28 08:50:36 UTC
[GitHub] [ignite-3] Cyrill commented on a diff in pull request #2627: IGNITE-20486 Protect write intent resolution with busy locks
Cyrill commented on code in PR #2627:
URL: https://github.com/apache/ignite-3/pull/2627#discussion_r1339764114
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1507,31 +1507,33 @@ private CompletableFuture<BinaryRow> resolveRowByPkForReadOnly(BinaryTuple pk, H
// This means that we can just resolve the state of this transaction.
checkWriteIntentsBelongSameTx(writeIntents);
- return resolveWriteIntentReadability(writeIntent, ts)
- .thenApply(writeIntentReadable -> {
- if (writeIntentReadable) {
- return findAny(writeIntents, wi -> !wi.isEmpty()).map(ReadResult::binaryRow).orElse(null);
- } else {
- for (ReadResult wi : writeIntents) {
- HybridTimestamp newestCommitTimestamp = wi.newestCommitTimestamp();
+ return inBusyLockAsync(busyLock, () ->
+ resolveWriteIntentReadability(writeIntent, ts)
+ .thenApply(writeIntentReadable -> {
Review Comment:
No it does not.
Fixed, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org