[jira] [Created] (THRIFT-2395) thrift Ruby gem requires development dependency 'thin' regardless of environment

["Tim Schmelmer (JIRA)" <ji...@apache.org>]

Tim Schmelmer created THRIFT-2395:
-------------------------------------

             Summary: thrift Ruby gem requires development dependency 'thin' regardless of environment 
                 Key: THRIFT-2395
                 URL: https://issues.apache.org/jira/browse/THRIFT-2395
             Project: Thrift
          Issue Type: Bug
          Components: Ruby - Library
    Affects Versions: 0.9.1
         Environment: Ruby 1.9.3-p484, Rails 3.0.20
            Reporter: Tim Schmelmer


The thrift library requires the thin (HTTP webserver) uncoditionally, see thrift-0.9.1/lib/thrift.rb (ll. 59 - 65):
# server
require 'thrift/server/base_server'
require 'thrift/server/nonblocking_server'
require 'thrift/server/simple_server'
require 'thrift/server/threaded_server'
require 'thrift/server/thread_pool_server'
require 'thrift/server/thin_http_server' 

As there is no gemspec to require the thin gem (in development group or other), bundler will not find this gem dependency.
Additionally, this dependency should only be required in development mode (as listed on rubygems: https://rubygems.org/gems/thrift/versions/0.9.1), so applications running in a production mode / environment should not need to depend on Thin at all, even if they use thrift.



--
This message was sent by Atlassian JIRA
(v6.2#6252)