You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/10 12:38:02 UTC
[GitHub] [airflow] dszakallas opened a new pull request #10859: Option to run worker task as container args in k8s
dszakallas opened a new pull request #10859:
URL: https://github.com/apache/airflow/pull/10859
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #8495
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Adds the `kubernetes.run_as_args` configuration option. When set to `True` the K8s executor will place the task runner command in the container's `args` field instead of `command` so that a custom entrypoint can be used.
Merge #10393 first
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dszakallas commented on pull request #10859: Option to run worker task as container args in k8s
Posted by GitBox <gi...@apache.org>.
dszakallas commented on pull request #10859:
URL: https://github.com/apache/airflow/pull/10859#issuecomment-691954891
Also, see this comment: https://github.com/apache/airflow/pull/10481#issuecomment-691953749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #10859: Option to run worker task as container args in k8s
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10859:
URL: https://github.com/apache/airflow/pull/10859#issuecomment-792130086
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on pull request #10859: Option to run worker task as container args in k8s
Posted by GitBox <gi...@apache.org>.
pingzh commented on pull request #10859:
URL: https://github.com/apache/airflow/pull/10859#issuecomment-691558342
Good point, i had a similar pr before: https://github.com/apache/airflow/pull/10481. It is important to not override the entrypoint of the user's image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #10859: Option to run worker task as container args in k8s
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #10859:
URL: https://github.com/apache/airflow/pull/10859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org