[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1334: MINIFICPP-1803 Do not instantiate all classes at heartbeat

[GitBox <gi...@apache.org>]

fgerlits commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r885490057


##########
extensions/http-curl/protocols/RESTSender.cpp:
##########
@@ -172,10 +167,6 @@ C2Payload RESTSender::sendPayload(const std::string url, const Direction directi
   }
 }
 
-REGISTER_RESOURCE(RESTSender, "Encapsulates the restful protocol that is built upon C2Protocol.");
+REGISTER_RESOURCE(RESTSender, DescriptionOnly);

Review Comment:
   This is a bit of a mess, but it was already like that before this PR:
   - `InternalResource` means it inherits from either `Processor` or `ControllerService`, but should not be included in the manifest.  These do not have a `Description` field.
   - `DescriptionOnly` means it does not inherit from `Processor` or `ControllerService`, so it will not be included in the manifest, but it does have a `Description` field (which I don't think we use anywhere, but I'm not sure, so I did not want to remove it).
   
   If these `Description`s are in fact not needed, then we could simplify this to:
   - if it has a `Description`, then include it in the manifest, detect whether it is a `Processor` or `ControllerService`, and throw a compile error if it's neither;
   - if it doesn't have a `Description`, then only register it in the class loader, and skip it in `agent_docs.h` etc completely.
   
   Should we do this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org