You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucy.apache.org by "Logan Bell (JIRA)" <ji...@apache.org> on 2012/08/15 20:15:38 UTC
[lucy-issues] [jira] [Created] (LUCY-243) Trap remove errno and warn
Logan Bell created LUCY-243:
-------------------------------
Summary: Trap remove errno and warn
Key: LUCY-243
URL: https://issues.apache.org/jira/browse/LUCY-243
Project: Lucy
Issue Type: Bug
Affects Versions: 0.3.3, 0.4.0
Reporter: Logan Bell
Priority: Minor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[lucy-issues] [jira] [Updated] (LUCY-243) Trap remove errno and warn
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey updated LUCY-243:
---------------------------------
Affects Version/s: (was: 0.3.3)
(was: 0.4.0)
0.3.0 (incubating)
0.3.1
0.3.2
Fix Version/s: 0.3.3
> Trap remove errno and warn
> --------------------------
>
> Key: LUCY-243
> URL: https://issues.apache.org/jira/browse/LUCY-243
> Project: Lucy
> Issue Type: Bug
> Affects Versions: 0.3.0 (incubating), 0.3.1, 0.3.2
> Reporter: Logan Bell
> Priority: Minor
> Fix For: 0.3.3
>
> Attachments: 0001-LUCY-243-Check-for-remove-failures-and-warn-errno.patch, 0001-LUCY-243-Improve-robustness-of-file-deletion.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[lucy-issues] [jira] [Updated] (LUCY-243) Trap remove errno and warn
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey updated LUCY-243:
---------------------------------
Attachment: 0002-Zap-unused-functions-remove_exe-remove_obj.patch
0001-LUCY-243-Check-for-remove-failures-and-warn-errno.patch
Here's a version for trunk.
It's slightly different from the one on 0.3... I think I have followed all the
possible paths and that no failed remove() call could cause a bail-out without
a warning.
As an added bonus, some unused functions go away in a second patch.
> Trap remove errno and warn
> --------------------------
>
> Key: LUCY-243
> URL: https://issues.apache.org/jira/browse/LUCY-243
> Project: Lucy
> Issue Type: Bug
> Affects Versions: 0.3.3, 0.4.0
> Reporter: Logan Bell
> Priority: Minor
> Attachments: 0001-LUCY-243-Check-for-remove-failures-and-warn-errno.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[lucy-issues] [jira] [Commented] (LUCY-243) Trap remove errno and warn
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437192#comment-13437192 ]
Marvin Humphrey commented on LUCY-243:
--------------------------------------
Other similar test results:
[http://cpantesters.org/cpan/report/14256dac-6893-11e1-ba5b-ffa051838b10]
[http://cpantesters.org/cpan/report/db586700-63e1-11e1-b759-ec922b0aa2c1]
> Trap remove errno and warn
> --------------------------
>
> Key: LUCY-243
> URL: https://issues.apache.org/jira/browse/LUCY-243
> Project: Lucy
> Issue Type: Bug
> Affects Versions: 0.3.3, 0.4.0
> Reporter: Logan Bell
> Priority: Minor
> Attachments: 0001-LUCY-243-Check-for-remove-failures-and-warn-errno.patch, 0001-LUCY-243-Improve-robustness-of-file-deletion.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[lucy-issues] [jira] [Updated] (LUCY-243) Trap remove errno and warn
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey updated LUCY-243:
---------------------------------
Attachment: 0002-Zap-unused-functions-remove_exe-remove_obj.patch
0001-LUCY-243-Improve-robustness-of-file-deletion.patch
Here's a more aggressive take.
Hopefully it will solve problems like this one:
[http://cpantesters.org/cpan/report/ba6dd428-cd02-11e1-a7a5-8774af2412a2]
{noformat}
Initializing Charmonizer/Core/OperatingSystem...
Trying to find a bit-bucket a la /dev/null...
Creating compiler object...
Trying to compile a small test file...
Initialization complete.
Running DirManip module...
Running Headers module...
Running AtomicOps module...
Running FuncMacro module...
Failed to delete file '_charmonizer_try.exe'
Failed to write charmony.h: Inappropriate I/O control operation at buildlib/Lucy/Build.pm line 193.
{noformat}
> Trap remove errno and warn
> --------------------------
>
> Key: LUCY-243
> URL: https://issues.apache.org/jira/browse/LUCY-243
> Project: Lucy
> Issue Type: Bug
> Affects Versions: 0.3.3, 0.4.0
> Reporter: Logan Bell
> Priority: Minor
> Attachments: 0001-LUCY-243-Check-for-remove-failures-and-warn-errno.patch, 0001-LUCY-243-Improve-robustness-of-file-deletion.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[lucy-issues] [jira] [Commented] (LUCY-243) Trap remove errno and warn
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439185#comment-13439185 ]
Marvin Humphrey commented on LUCY-243:
--------------------------------------
I committed an updated version of the more aggressive patch as
r1375860, attempting to blend the work done by Logan on this
issue with Nick's patch from LUCY-245. It was backported to the
0.3 branch as r1375861.
> Trap remove errno and warn
> --------------------------
>
> Key: LUCY-243
> URL: https://issues.apache.org/jira/browse/LUCY-243
> Project: Lucy
> Issue Type: Bug
> Affects Versions: 0.3.3, 0.4.0
> Reporter: Logan Bell
> Priority: Minor
> Attachments: 0001-LUCY-243-Check-for-remove-failures-and-warn-errno.patch, 0001-LUCY-243-Improve-robustness-of-file-deletion.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[lucy-issues] [jira] [Resolved] (LUCY-243) Trap remove errno and warn
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey resolved LUCY-243.
----------------------------------
Resolution: Fixed
Resolving the issue, though since nobody can duplicate the
problem, we may have to reopen later.
> Trap remove errno and warn
> --------------------------
>
> Key: LUCY-243
> URL: https://issues.apache.org/jira/browse/LUCY-243
> Project: Lucy
> Issue Type: Bug
> Affects Versions: 0.3.0 (incubating), 0.3.1, 0.3.2
> Reporter: Logan Bell
> Priority: Minor
> Fix For: 0.3.3
>
> Attachments: 0001-LUCY-243-Check-for-remove-failures-and-warn-errno.patch, 0001-LUCY-243-Improve-robustness-of-file-deletion.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch, 0002-Zap-unused-functions-remove_exe-remove_obj.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira