You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/21 08:10:50 UTC

[GitHub] [spark] zhengruifeng opened a new pull request #35593: [SPARK-38271] PoissonSampler may generate more rows than MaxRows

zhengruifeng opened a new pull request #35593:
URL: https://github.com/apache/spark/pull/35593


   ### What changes were proposed in this pull request?
   when `replacement=true`, `Sample.maxRows` returns `None`
   
   
   ### Why are the changes needed?
   the underlying impl of `SampleExec` can not guarantee that its number of output rows <= `Sample.maxRows`
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   existing testsuites


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #35593: [SPARK-38271] PoissonSampler may output more rows than MaxRows

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35593:
URL: https://github.com/apache/spark/pull/35593#issuecomment-1047776243


   thanks, merging to master/3.2!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #35593: [SPARK-38271] PoissonSampler may generate more rows than MaxRows

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #35593:
URL: https://github.com/apache/spark/pull/35593#issuecomment-1047567350


   @cloud-fan Sure, will add a ut today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #35593: [SPARK-38271] PoissonSampler may generate more rows than MaxRows

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #35593:
URL: https://github.com/apache/spark/pull/35593#issuecomment-1046583111


   cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #35593: [SPARK-38271] PoissonSampler may output more rows than MaxRows

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #35593:
URL: https://github.com/apache/spark/pull/35593


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #35593: [SPARK-38271] PoissonSampler may generate more rows than MaxRows

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35593:
URL: https://github.com/apache/spark/pull/35593#issuecomment-1047565682


   can we add a UT for it in `CombiningLimitsSuite`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org