[GitHub] [ozone] adoroszlai commented on a change in pull request #3122: HDDS-6361. Modify docs build flow to replace image tags with shortcodes.

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #3122:
URL: https://github.com/apache/ozone/pull/3122#discussion_r812915703



##########
File path: hadoop-hdds/docs/dev-support/bin/generate-site.sh
##########
@@ -31,11 +31,18 @@ if git -C $(pwd) status >& /dev/null; then
   ENABLE_GIT_INFO="--enableGitInfo"
 fi
 
-# Replace all markdown images with a responsive hugo shortcode.
-python3 $DIR/make_images_responsive.py $DOCDIR
+# Copy docs files to a temporary directory inside target
+# for pre-processing the markdown files.
+TMPDIR="$DOCDIR/target/tmp"
+mkdir -p "$TMPDIR"
+rsync -a --exclude="$DOCDIR/target" --exclude="$DOCDIR/public" "$DOCDIR/" "$TMPDIR"

Review comment:
       Thanks @JyotinderSingh for updating the patch.
   
   Repeated `mvn package` increases the depth of the hierarchy (`target/tmp/target/tmp/target/tmp`, etc.).
   
   ```suggestion
   mkdir -p "$TMPDIR"
   rsync -a --exclude="target" --exclude="public" "$DOCDIR/" "$TMPDIR"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org