You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/03 21:14:39 UTC
[GitHub] zachgk commented on a change in pull request #13626: Re-organize
Scala maven build
zachgk commented on a change in pull request #13626: Re-organize Scala maven build
URL: https://github.com/apache/incubator-mxnet/pull/13626#discussion_r244889193
##########
File path: scala-package/README.md
##########
@@ -114,30 +114,51 @@ Also, add the dependency which corresponds to your platform to the ```dependenci
**Note:** ```<version>[1.5.0,)<\version>``` indicates that we will fetch packages with version 1.5.0 or higher. This will always ensure that the pom.xml is able to fetch the latest and greatest jar files from Maven Snapshot repository.
Build From Source
-------------
+-----------------
-Checkout the [Installation Guide](http://mxnet.incubator.apache.org/install/index.html) contains instructions to install mxnet package and build it from source.
-If you have built MXNet from source and are looking to setup Scala from that point, you may simply run the following from the MXNet source root:
+Checkout the [Installation Guide](http://mxnet.incubator.apache.org/install/index.html) contains instructions to install mxnet package and build it from source. Scala maven build assume you already have a ``lib/libmxnet.so`` file.
+If you have built MXNet from source and are looking to setup Scala from that point, you may simply run the following from the MXNet source root, Scala build will detect your platform (OSX/Linux) and libmxnet.so flavor (CPU/GPU):
```bash
-make scalapkg
+cd scala-package
+mvn install
```
You can also run the unit tests and integration tests on the Scala Package by :
```bash
-make scalaunittest
-make scalaintegrationtest
+cd scala-package
+mvn integration-test -DskipTests=false
```
Or run a subset of unit tests, for e.g.,
```bash
-make SCALA_TEST_ARGS=-Dsuites=org.apache.mxnet.NDArraySuite scalaunittest
+cd scala-package
+mvn -DSCALA_TEST_ARGS=-Dsuites=org.apache.mxnet.NDArraySuite integration-test
Review comment:
I think this should just be `mvn -Dsuites=org.apache.mxnet.NDArraySuite integration-test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services