You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2016/11/10 21:22:59 UTC

[jira] [Created] (BEAM-961) CountingInput could have starting number

Kenneth Knowles created BEAM-961:
------------------------------------

             Summary: CountingInput could have starting number
                 Key: BEAM-961
                 URL: https://issues.apache.org/jira/browse/BEAM-961
             Project: Beam
          Issue Type: New Feature
          Components: sdk-java-core
            Reporter: Kenneth Knowles
            Priority: Trivial


TL;DR: Add {{startingAt}} to {{CountingInput}}.

Right now you can have {{CountingInput.upTo(someNumber)}} but it came up in a test that if you want to have, say, one PCollection that is 1 through 10 and another that is 11 through 20 - so you know they are disjoint - then it requires some boilerplate to add 10 to every element. That boilerplate should be part of the {{CountingInput}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Created] (BEAM-961) CountingInput could have starting number

Posted by Kenneth Knowles <kl...@google.com.INVALID>.
I'm not particular about whether the source itself does it versus replacing
uses of the source with a new PTransform encapsulating them. As long as
there is some object with `startingAt` and `upTo`. Either way should be
easy? Left it with starter tag as it would potentially be a fun initial
dive into the codebase.

On Thu, Nov 10, 2016 at 1:23 PM, Dan Halperin <dh...@google.com> wrote:

> Why not support this in a follow-on pardo that shifts the range?
>
> On Thu, Nov 10, 2016 at 1:22 PM, Kenneth Knowles (JIRA) <ji...@apache.org>
> wrote:
>
>> Kenneth Knowles created BEAM-961:
>> ------------------------------------
>>
>>              Summary: CountingInput could have starting number
>>                  Key: BEAM-961
>>                  URL: https://issues.apache.org/jira/browse/BEAM-961
>>              Project: Beam
>>           Issue Type: New Feature
>>           Components: sdk-java-core
>>             Reporter: Kenneth Knowles
>>             Priority: Trivial
>>
>>
>> TL;DR: Add {{startingAt}} to {{CountingInput}}.
>>
>> Right now you can have {{CountingInput.upTo(someNumber)}} but it came up
>> in a test that if you want to have, say, one PCollection that is 1 through
>> 10 and another that is 11 through 20 - so you know they are disjoint - then
>> it requires some boilerplate to add 10 to every element. That boilerplate
>> should be part of the {{CountingInput}}
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>

Re: [jira] [Created] (BEAM-961) CountingInput could have starting number

Posted by Kenneth Knowles <kl...@google.com>.
I'm not particular about whether the source itself does it versus replacing
uses of the source with a new PTransform encapsulating them. As long as
there is some object with `startingAt` and `upTo`. Either way should be
easy? Left it with starter tag as it would potentially be a fun initial
dive into the codebase.

On Thu, Nov 10, 2016 at 1:23 PM, Dan Halperin <dh...@google.com> wrote:

> Why not support this in a follow-on pardo that shifts the range?
>
> On Thu, Nov 10, 2016 at 1:22 PM, Kenneth Knowles (JIRA) <ji...@apache.org>
> wrote:
>
>> Kenneth Knowles created BEAM-961:
>> ------------------------------------
>>
>>              Summary: CountingInput could have starting number
>>                  Key: BEAM-961
>>                  URL: https://issues.apache.org/jira/browse/BEAM-961
>>              Project: Beam
>>           Issue Type: New Feature
>>           Components: sdk-java-core
>>             Reporter: Kenneth Knowles
>>             Priority: Trivial
>>
>>
>> TL;DR: Add {{startingAt}} to {{CountingInput}}.
>>
>> Right now you can have {{CountingInput.upTo(someNumber)}} but it came up
>> in a test that if you want to have, say, one PCollection that is 1 through
>> 10 and another that is 11 through 20 - so you know they are disjoint - then
>> it requires some boilerplate to add 10 to every element. That boilerplate
>> should be part of the {{CountingInput}}
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>

Re: [jira] [Created] (BEAM-961) CountingInput could have starting number

Posted by Dan Halperin <dh...@google.com>.
Why not support this in a follow-on pardo that shifts the range?

On Thu, Nov 10, 2016 at 1:22 PM, Kenneth Knowles (JIRA) <ji...@apache.org>
wrote:

> Kenneth Knowles created BEAM-961:
> ------------------------------------
>
>              Summary: CountingInput could have starting number
>                  Key: BEAM-961
>                  URL: https://issues.apache.org/jira/browse/BEAM-961
>              Project: Beam
>           Issue Type: New Feature
>           Components: sdk-java-core
>             Reporter: Kenneth Knowles
>             Priority: Trivial
>
>
> TL;DR: Add {{startingAt}} to {{CountingInput}}.
>
> Right now you can have {{CountingInput.upTo(someNumber)}} but it came up
> in a test that if you want to have, say, one PCollection that is 1 through
> 10 and another that is 11 through 20 - so you know they are disjoint - then
> it requires some boilerplate to add 10 to every element. That boilerplate
> should be part of the {{CountingInput}}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>

Re: [jira] [Created] (BEAM-961) CountingInput could have starting number

Posted by Dan Halperin <dh...@google.com.INVALID>.
Why not support this in a follow-on pardo that shifts the range?

On Thu, Nov 10, 2016 at 1:22 PM, Kenneth Knowles (JIRA) <ji...@apache.org>
wrote:

> Kenneth Knowles created BEAM-961:
> ------------------------------------
>
>              Summary: CountingInput could have starting number
>                  Key: BEAM-961
>                  URL: https://issues.apache.org/jira/browse/BEAM-961
>              Project: Beam
>           Issue Type: New Feature
>           Components: sdk-java-core
>             Reporter: Kenneth Knowles
>             Priority: Trivial
>
>
> TL;DR: Add {{startingAt}} to {{CountingInput}}.
>
> Right now you can have {{CountingInput.upTo(someNumber)}} but it came up
> in a test that if you want to have, say, one PCollection that is 1 through
> 10 and another that is 11 through 20 - so you know they are disjoint - then
> it requires some boilerplate to add 10 to every element. That boilerplate
> should be part of the {{CountingInput}}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>