You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mark Struberg (JIRA)" <de...@myfaces.apache.org> on 2012/11/13 19:20:11 UTC
[jira] [Created] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Mark Struberg created MYFACES-3638:
--------------------------------------
Summary: NPE in ServerSideStateCacheImpl
Key: MYFACES-3638
URL: https://issues.apache.org/jira/browse/MYFACES-3638
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 2.1.9
Reporter: Mark Struberg
Assignee: Mark Struberg
I'm getting the following NPE when having a request which leads to a 404:
{code}
Nov 9 09:00:45 j02 java.lang.NullPointerException
Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-3638.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.16
Fixed and updated 2.0.x branch. 2.2.x and 2.1.x-client-window branches will be updated in a further svn merge over 2.1.x
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Fix For: 2.0.16, 2.1.10
>
> Attachments: MYFACES-3638-alternate-fix-1.patch, MYFACES-3638.patch, MYFACES-3638-proposal.diff
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg updated MYFACES-3638:
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.1.10
Status: Resolved (was: Patch Available)
patch committed as well. txs to Bütt for the patch
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Fix For: 2.1.10
>
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe reopened MYFACES-3638:
-------------------------------------
Reopening issue to include solution without refactoring of server side state saving code. Also we need to fix this one too (happens when org.apache.myfaces.SUPPORT_JSP_AND_FACES_EL web config param is set to false)
javax.faces.FacesException: Cannot find a valid PDL for view id /hxome.view.xml
org.apache.myfaces.view.ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(ViewDeclarationLanguageFactoryImpl.java:93)
org.apache.myfaces.application.ViewHandlerImpl.getViewDeclarationLanguage(ViewHandlerImpl.java:179)
org.apache.myfaces.shared.application.DefaultViewHandlerSupport.checkResourceExists(DefaultViewHandlerSupport.java:546)
org.apache.myfaces.shared.application.DefaultViewHandlerSupport.handleSuffixMapping(DefaultViewHandlerSupport.java:484)
org.apache.myfaces.shared.application.DefaultViewHandlerSupport.calculateViewId(DefaultViewHandlerSupport.java:114)
org.apache.myfaces.application.ViewHandlerImpl.deriveLogicalViewId(ViewHandlerImpl.java:118)
org.apache.myfaces.lifecycle.RestoreViewExecutor.execute(RestoreViewExecutor.java:157)
org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:170)
org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117)
javax.faces.webapp.FacesServlet.service(FacesServlet.java:197)
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Fix For: 2.1.10
>
> Attachments: MYFACES-3638.patch, MYFACES-3638-proposal.diff
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Marcus Büttner (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496953#comment-13496953 ]
Marcus Büttner commented on MYFACES-3638:
-----------------------------------------
After calling dispatcher in JspViewDeclarationLanguage which returns 404 the response is committed and response status is 404. Why we should continue with the whole rendering process? Mojarra does a responseComplete() in that case.
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496702#comment-13496702 ]
Leonardo Uribe commented on MYFACES-3638:
-----------------------------------------
I think it is necessary to provide concrete proof of key clashing in this case. In theory, the sequenceId ensure uniqueness, and it is always added, so there is no way to have a problem like that. The issue in this case is that JspViewDeclarationLanguageBase.renderView method calls saveState for a null view, which is unexpected. It does not have sense to save a view with null viewId. This is a leftover of the old algorithm used in MyFaces 1.2, and in this case, do a check for null viewId is completely reasonable.
In my opinion the call to responseComplete() is not necessary, but maybe we should review this part to ensure it works as expected.
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Marcus Büttner (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcus Büttner updated MYFACES-3638:
------------------------------------
Status: Patch Available (was: Open)
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved MYFACES-3638.
------------------------------------
Resolution: Fixed
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Fix For: 2.0.16, 2.1.10
>
> Attachments: MYFACES-3638-alternate-fix-1.patch, MYFACES-3638.patch, MYFACES-3638-proposal.diff
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496608#comment-13496608 ]
Mark Struberg commented on MYFACES-3638:
----------------------------------------
I've committed a refactoring of that area which solves the key clashes and also the NPE.
We might additionally add the attached patch, but this needs an in depth review of the possible error handling scenarios first.
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496988#comment-13496988 ]
Jakob Korherr commented on MYFACES-3638:
----------------------------------------
404 should force an immediate responseComplete() IMHO.
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496705#comment-13496705 ]
Mark Struberg commented on MYFACES-3638:
----------------------------------------
The sequenceId is not even used in the problematic code. It solely compares the viewIds.
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg reopened MYFACES-3638:
------------------------------------
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Fix For: 2.0.16, 2.1.10
>
> Attachments: MYFACES-3638-alternate-fix-1.patch, MYFACES-3638.patch, MYFACES-3638-proposal.diff
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496485#comment-13496485 ]
Mark Struberg commented on MYFACES-3638:
----------------------------------------
That sounds perfectly reasonable.
Is there some edge case where the FaceletViewDeclarationLanguage could have the same problem?
And what about error pages afterwards? If we set responseComplete() does this have some effect on the error handling on our side?
Will need to think through the different use cases.
In any case the caching algorithm needs improvement and can be done much simpler without affecting the performance. The current impl potentially creates key clashes and must get fixed anyway. I'm working on that already.
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: MYFACES-3638.patch
>
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3638) NPE in ServerSideStateCacheImpl
Posted by "Marcus Büttner (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496480#comment-13496480 ]
Marcus Büttner commented on MYFACES-3638:
-----------------------------------------
In my opionen a request which leads to 404 must not be rendered. But the JspViewDeclarationLanguage doesn't stop the lifecylce after dispatcher returns an error status (e.g. 404) in JspViewDeclarationLanguage#buildView. I think a responseComplete is missed.
> NPE in ServerSideStateCacheImpl
> -------------------------------
>
> Key: MYFACES-3638
> URL: https://issues.apache.org/jira/browse/MYFACES-3638
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.1.9
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> I'm getting the following NPE when having a request which leads to a 404:
> {code}
> Nov 9 09:00:45 j02 java.lang.NullPointerException
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1413)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl$CounterSessionViewStorageFactory.createSerializedViewKey(ServerSideStateCacheImpl.java:1392)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedViewInServletSession(ServerSideStateCacheImpl.java:318)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.ServerSideStateCacheImpl.saveSerializedView(ServerSideStateCacheImpl.java:1036)
> Nov 9 09:00:45 j02 at org.apache.myfaces.renderkit.html.HtmlResponseStateManager.saveState(HtmlResponseStateManager.java:149)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.StateManagerImpl.saveView(StateManagerImpl.java:253)
> Nov 9 09:00:45 j02 at org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:221)
> Nov 9 09:00:45 j02 at org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:285)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.tomahawk.application.ResourceViewHandlerWrapper.renderView(ResourceViewHandlerWrapper.java:93)
> Nov 9 09:00:45 j02 at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:59)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> Nov 9 09:00:45 j02 at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241)
> Nov 9 09:00:45 j02 at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.render(CodiLifecycleWrapper.java:126)
> Nov 9 09:00:45 j02 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira