You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/07/23 09:36:48 UTC
[GitHub] [lucene-solr] dweiss opened a new pull request #1689: LUCENE-9439: Matches API should enumerate hit fields that have no positions (support empty iterator)
dweiss opened a new pull request #1689:
URL: https://github.com/apache/lucene-solr/pull/1689
A minimally-intrusive patch that seems to work just fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss closed pull request #1689: LUCENE-9439: Matches API should enumerate hit fields that have no positions (support empty iterator)
Posted by GitBox <gi...@apache.org>.
dweiss closed pull request #1689:
URL: https://github.com/apache/lucene-solr/pull/1689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #1689: LUCENE-9439: Matches API should enumerate hit fields that have no positions (support empty iterator)
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #1689:
URL: https://github.com/apache/lucene-solr/pull/1689#discussion_r459332378
##########
File path: lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java
##########
@@ -195,7 +195,9 @@ public Matches matches(LeafReaderContext context, int doc) throws IOException {
return null;
}
}
- return MatchesUtils.MATCH_WITH_NO_TERMS;
+
+ // TODO: which fields should be here?
Review comment:
This bit I wasn't really sure about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org