Re: [I] Do we suboptimally call ByteBuffersDataOutput.toDataInput()? [lucene]

["mikemccand (via GitHub)" <gi...@apache.org>]

mikemccand commented on issue #12852:
URL: https://github.com/apache/lucene/issues/12852#issuecomment-1840648672

   At least we should add a warning to the javadocs here.
   
   And we should audit other places that are frequently calling `.toDataInput()` (e.g. block tree terms dict writing?).
   
   This method is surprisingly slow compared to simply juggling our own `byte[]` under the hood, at least in FST's (well, `Test2BFSTs`) usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org