You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/07/03 16:30:32 UTC
[GitHub] [yunikorn-core] steinsgateted opened a new pull request, #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
steinsgateted opened a new pull request, #421:
URL: https://github.com/apache/yunikorn-core/pull/421
### What is this PR for?
add timed out placeholders count in application REST info and add some placeholderData tests
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1252
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] steinsgateted commented on a diff in pull request #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on code in PR #421:
URL: https://github.com/apache/yunikorn-core/pull/421#discussion_r919258456
##########
pkg/webservice/dao/application_info.go:
##########
@@ -48,4 +48,5 @@ type PlaceholderDAOInfo struct {
Count int64 `json:"count"`
MinResource map[string]int64 `json:"minResource"`
Replaced int64 `json:"replaced"`
+ Timeout int64 `json:"timeout"`
Review Comment:
Done.Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] steinsgateted commented on pull request #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on PR #421:
URL: https://github.com/apache/yunikorn-core/pull/421#issuecomment-1182149205
@wilfred-s Thanks for your review.
In `application.go`, add a `SetTimedOutPlaceholder` func for handler test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on code in PR #421:
URL: https://github.com/apache/yunikorn-core/pull/421#discussion_r918871099
##########
pkg/webservice/handlers.go:
##########
@@ -240,6 +240,7 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
Count: taskGroup.Count,
MinResource: taskGroup.MinResource.DAOMap(),
Replaced: taskGroup.Replaced,
+ Timeout: taskGroup.Timedout,
Review Comment:
Missing "d" in the name: Time**d**Out Also capitalise the `O`
##########
pkg/webservice/dao/application_info.go:
##########
@@ -48,4 +48,5 @@ type PlaceholderDAOInfo struct {
Count int64 `json:"count"`
MinResource map[string]int64 `json:"minResource"`
Replaced int64 `json:"replaced"`
+ Timeout int64 `json:"timeout"`
Review Comment:
Missing "d" in the name: Time**d**Out Also capitalise the `O`
json field should be timedout also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] steinsgateted commented on a diff in pull request #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
Posted by GitBox <gi...@apache.org>.
steinsgateted commented on code in PR #421:
URL: https://github.com/apache/yunikorn-core/pull/421#discussion_r919259079
##########
pkg/webservice/handlers.go:
##########
@@ -240,6 +240,7 @@ func getApplicationJSON(app *objects.Application) *dao.ApplicationDAOInfo {
Count: taskGroup.Count,
MinResource: taskGroup.MinResource.DAOMap(),
Replaced: taskGroup.Replaced,
+ Timeout: taskGroup.Timedout,
Review Comment:
Done.Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
URL: https://github.com/apache/yunikorn-core/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #421: [YUNIKORN-1252] expose timed out placeholders count in application REST info
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #421:
URL: https://github.com/apache/yunikorn-core/pull/421#issuecomment-1173132149
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/421?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#421](https://codecov.io/gh/apache/yunikorn-core/pull/421?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c21c2b) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/9aba37d8748e4ebf812f5720d736870c64ed7306?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9aba37d) will **increase** coverage by `0.16%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 69.17% 69.34% +0.16%
==========================================
Files 68 68
Lines 9846 9847 +1
==========================================
+ Hits 6811 6828 +17
+ Misses 2791 2777 -14
+ Partials 244 242 -2
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/421/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `69.18% <100.00%> (+2.46%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/421?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/421?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9aba37d...3c21c2b](https://codecov.io/gh/apache/yunikorn-core/pull/421?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org