You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eventmesh.apache.org by we...@apache.org on 2022/01/17 14:56:48 UTC
[incubator-eventmesh] branch master updated: Remove unnecessary call toString (#719)
This is an automated email from the ASF dual-hosted git repository.
wenjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 7625d3c Remove unnecessary call toString (#719)
7625d3c is described below
commit 7625d3c88a908a1699d2de5aba6a693d1428d8a6
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Mon Jan 17 22:56:40 2022 +0800
Remove unnecessary call toString (#719)
---
.../java/org/apache/eventmesh/connector/rocketmq/utils/OMSUtil.java | 2 +-
.../runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java | 2 +-
.../core/protocol/tcp/client/session/send/UpStreamMsgContext.java | 4 ++--
.../runtime/core/protocol/tcp/client/task/MessageTransferTask.java | 2 +-
.../main/java/org/apache/eventmesh/runtime/util/RemotingHelper.java | 2 +-
.../java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java | 2 +-
.../java/org/apache/eventmesh/runtime/client/impl/SubClientImpl.java | 2 +-
.../src/test/java/org/apache/eventmesh/runtime/demo/CClientDemo.java | 2 +-
.../test/java/org/apache/eventmesh/runtime/demo/SyncPubClient.java | 2 +-
.../test/java/org/apache/eventmesh/runtime/demo/SyncSubClient.java | 2 +-
10 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/utils/OMSUtil.java b/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/utils/OMSUtil.java
index 7d00e80..b284a37 100644
--- a/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/utils/OMSUtil.java
+++ b/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/utils/OMSUtil.java
@@ -27,7 +27,7 @@ public class OMSUtil {
* @return a unique instance name
*/
public static String buildInstanceName() {
- return Integer.toString(UtilAll.getPid()) + "%EventMesh" + "%" + System.nanoTime();
+ return UtilAll.getPid() + "%EventMesh" + "%" + System.nanoTime();
}
//public static org.apache.rocketmq.common.message.Message msgConvert(Message omsMessage) {
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java
index 0b3e4db..091f510 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java
@@ -666,7 +666,7 @@ public class ClientGroupWrapper {
HttpTinyClient.HttpResult result = null;
try {
- logger.info("pushMsgToEventMesh,targetUrl:{},msg:{}", targetUrl.toString(),
+ logger.info("pushMsgToEventMesh,targetUrl:{},msg:{}", targetUrl,
msg);
List<String> paramValues = new ArrayList<String>();
paramValues.add("msg");
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/UpStreamMsgContext.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/UpStreamMsgContext.java
index 2950f2f..f4e1886 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/UpStreamMsgContext.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/UpStreamMsgContext.java
@@ -115,7 +115,7 @@ public class UpStreamMsgContext extends RetryContext {
public void onSuccess(SendResult sendResult) {
session.getSender().getUpstreamBuff().release();
logger.info("upstreamMsg message success|user={}|callback cost={}", session.getClient(),
- String.valueOf(System.currentTimeMillis() - createTime));
+ System.currentTimeMillis() - createTime);
if (replyCmd.equals(Command.BROADCAST_MESSAGE_TO_SERVER_ACK) || replyCmd.equals(Command
.ASYNC_MESSAGE_TO_SERVER_ACK)) {
msg.setHeader(new Header(replyCmd, OPStatus.SUCCESS.getCode(), OPStatus.SUCCESS.getDesc(), seq));
@@ -136,7 +136,7 @@ public class UpStreamMsgContext extends RetryContext {
session.getSender().failMsgCount.incrementAndGet();
logger.error("upstreamMsg mq message error|user={}|callback cost={}, errMsg={}", session.getClient(),
- String.valueOf(System.currentTimeMillis() - createTime), new Exception(context.getException()));
+ System.currentTimeMillis() - createTime, new Exception(context.getException()));
msg.setHeader(new Header(replyCmd, OPStatus.FAIL.getCode(), context.getException().toString(), seq));
msg.setBody(event);
Utils.writeAndFlush(msg, startTime, taskExecuteTime, session.getContext(), session);
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
index 442d539..ffcd199 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
@@ -177,7 +177,7 @@ public class MessageTransferTask extends AbstractTask {
public void onSuccess(SendResult sendResult) {
session.getSender().getUpstreamBuff().release();
messageLogger.info("upstreamMsg message success|user={}|callback cost={}", session.getClient(),
- String.valueOf(System.currentTimeMillis() - createTime));
+ System.currentTimeMillis() - createTime);
if (replyCmd.equals(Command.BROADCAST_MESSAGE_TO_SERVER_ACK) || replyCmd.equals(Command
.ASYNC_MESSAGE_TO_SERVER_ACK)) {
msg.setHeader(new Header(replyCmd, OPStatus.SUCCESS.getCode(), OPStatus.SUCCESS.getDesc(),
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/RemotingHelper.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/RemotingHelper.java
index 6bbff73..d8c3396 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/RemotingHelper.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/RemotingHelper.java
@@ -35,7 +35,7 @@ public class RemotingHelper {
public static String exceptionSimpleDesc(final Throwable e) {
StringBuilder sb = new StringBuilder();
if (e != null) {
- sb.append(e.toString());
+ sb.append(e);
StackTraceElement[] stackTrace = e.getStackTrace();
if (stackTrace != null && stackTrace.length > 0) {
diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
index f4293e7..2e76d7f 100644
--- a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
+++ b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java
@@ -203,7 +203,7 @@ public class PubClientImpl extends TCPClient implements PubClient {
return;
}
} else if (cmd == Command.SERVER_GOODBYE_REQUEST) {
- publogger.error("server goodby request: ---------------------------" + msg.toString());
+ publogger.error("server goodby request: ---------------------------" + msg);
close();
} else {
RequestContext context = contexts.get(RequestContext.key(msg));
diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/SubClientImpl.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/SubClientImpl.java
index 1d3b98c..6af8b4c 100644
--- a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/SubClientImpl.java
+++ b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/SubClientImpl.java
@@ -226,7 +226,7 @@ public class SubClientImpl extends TCPClient implements SubClient {
logger.info("send broadcast request to client ack failed");
}
} else if (cmd == Command.SERVER_GOODBYE_REQUEST) {
- logger.error("server goodby request: ---------------------------" + msg.toString());
+ logger.error("server goodby request: ---------------------------" + msg);
close();
} else {
//control instruction set
diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/CClientDemo.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/CClientDemo.java
index 9ebaf74..56b50a5 100644
--- a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/CClientDemo.java
+++ b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/CClientDemo.java
@@ -64,7 +64,7 @@ public class CClientDemo {
@Override
public void handle(Package msg, ChannelHandlerContext ctx) {
if (msg.getHeader().getCmd() == Command.ASYNC_MESSAGE_TO_CLIENT || msg.getHeader().getCmd() == Command.BROADCAST_MESSAGE_TO_CLIENT) {
- logger.error("receive message-------------------------------------" + msg.toString());
+ logger.error("receive message-------------------------------------" + msg);
}
}
});
diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncPubClient.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncPubClient.java
index 6375a3b..172c7a2 100644
--- a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncPubClient.java
+++ b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncPubClient.java
@@ -39,7 +39,7 @@ public class SyncPubClient {
Package rr = pubClient.rr(MessageUtils.rrMesssage("TEST-TOPIC-TCP-SYNC", i), 3000);
if (rr.getBody() instanceof EventMeshMessage) {
String body = ((EventMeshMessage) rr.getBody()).getBody();
- logger.error("rrMessage: " + body + " " + "rr-reply-------------------------------------------------" + rr.toString());
+ logger.error("rrMessage: " + body + " " + "rr-reply-------------------------------------------------" + rr);
}
}
}
diff --git a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncSubClient.java b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncSubClient.java
index 3e3ed20..f7d2f12 100644
--- a/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncSubClient.java
+++ b/eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/demo/SyncSubClient.java
@@ -44,7 +44,7 @@ public class SyncSubClient {
@Override
public void handle(Package msg, ChannelHandlerContext ctx) {
if (msg.getHeader().getCommand() == Command.REQUEST_TO_CLIENT) {
- logger.error("receive message -------------------------------" + msg.toString());
+ logger.error("receive message -------------------------------" + msg);
}
}
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org