You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/19 15:46:00 UTC

[jira] [Commented] (HUDI-2322) Only include meta fields to reorder while preparing dataset for bulk insert

    [ https://issues.apache.org/jira/browse/HUDI-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401725#comment-17401725 ] 

ASF GitHub Bot commented on HUDI-2322:
--------------------------------------

codope commented on pull request #3504:
URL: https://github.com/apache/hudi/pull/3504#issuecomment-902023373


   > @codope this does not seem like `MINOR`. can we file. JIRA for this fix
   
   Filed [JIRA](https://issues.apache.org/jira/browse/HUDI-2322) and updated PR title.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Only include meta fields to reorder while preparing dataset for bulk insert
> ---------------------------------------------------------------------------
>
>                 Key: HUDI-2322
>                 URL: https://issues.apache.org/jira/browse/HUDI-2322
>             Project: Apache Hudi
>          Issue Type: Bug
>            Reporter: Sagar Sumit
>            Assignee: Sagar Sumit
>            Priority: Major
>             Fix For: 0.9.0
>
>
> Below filter in `HoodieDatasetBulkInsertHelper` will result in `_hoodie_is_deleted` to be reordered as well even though it is not part of meta columns. 
> {code:java}
> List<Column> originalFields =
>         Arrays.stream(rowsWithMetaCols.schema().fields()).filter(field -> !field.name().contains("_hoodie_")).map(f -> new Column(f.name())).collect(Collectors.toList());
>     List<Column> metaFields =
>         Arrays.stream(rowsWithMetaCols.schema().fields()).filter(field -> field.name().contains("_hoodie_")).map(f -> new Column(f.name())).collect(Collectors.toList());
> {code}
> The fix is to check only for `HoodieRecord.HOODIE_META_COLUMNS_WITH_OPERATION`.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)