You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/15 02:28:53 UTC
[GitHub] [apisix] jbampton opened a new pull request #3045: feat(CI): add a GitHub Action to lint the shell
jbampton opened a new pull request #3045:
URL: https://github.com/apache/apisix/pull/3045
### What this PR does / why we need it:
Lints the shell scripts so we can standardize the codebase.
### Pre-submission checklist:
* [X] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3045: WIP - feat(CI): add a GitHub Action to lint the shell
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #3045:
URL: https://github.com/apache/apisix/pull/3045#issuecomment-754302720
CI failed. @juzhiyuan is github actions limited？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on pull request #3045: WIP - feat(CI): switch to using the GitHub Super-Linter
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #3045:
URL: https://github.com/apache/apisix/pull/3045#issuecomment-758494423
It looks like it is using the `token` and we don't have to set it. It outputs the `token` as empty near the top of the run.
By using the `token` it is meant to report back in the `checks` section for each language/check linted separately otherwise we just get the overall check listed in the PR on the main page.
We seem to have some errors and maybe this is related seen in the image below:
<img width="924" alt="Screen Shot 2021-01-12 at 6 23 26 pm" src="https://user-images.githubusercontent.com/418747/104288412-7b7d3c80-5503-11eb-9729-6be1bf4f1ff5.png">
Seen in the last run -> https://github.com/apache/apisix/pull/3045/checks?check_run_id=1686557482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3045: WIP - feat(CI): add a GitHub Action to lint the shell
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #3045:
URL: https://github.com/apache/apisix/pull/3045#issuecomment-754317753
@jbampton has not finished yet, as the "WIP" indicated. We need to be patient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3045: WIP - feat(CI): add a GitHub Action to lint the shell
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #3045:
URL: https://github.com/apache/apisix/pull/3045#issuecomment-757858416
@jbampton you need to rebase your branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3045: WIP - feat(CI): add a GitHub Action to lint the shell
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #3045:
URL: https://github.com/apache/apisix/pull/3045#issuecomment-754303765
> CI failed. @juzhiyuan is github actions limited？
I don't think so, it's failed due to lint errors 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton closed pull request #3045: WIP - feat(CI): switch to using the GitHub Super-Linter
Posted by GitBox <gi...@apache.org>.
jbampton closed pull request #3045:
URL: https://github.com/apache/apisix/pull/3045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3045: WIP - feat(CI): switch to using the GitHub Super-Linter
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #3045:
URL: https://github.com/apache/apisix/pull/3045#issuecomment-758483137
If `GITHUB_TOKEN` is optional, it would better to omit it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on pull request #3045: WIP - feat(CI): switch to using the GitHub Super-Linter
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #3045:
URL: https://github.com/apache/apisix/pull/3045#issuecomment-758469063
Pinging @spacewander
Do we have to set this in the repo settings?
From the site: "NOTE: If you pass the Environment variable GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} in your workflow, then the GitHub Super-Linter will mark the status of each individual linter run in the Checks section of a pull request. Without this you will only see the overall status of the full run. There is no need to set the GitHub Secret as it is automatically set by GitHub, it only needs to be passed to the action."
https://github.com/marketplace/actions/super-linter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org