You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li via Review Board <no...@reviews.apache.org> on 2017/11/22 21:16:49 UTC
Review Request 64040: SENTRY-2070: TestSentryShellSolr tests are case
sensitive to privileges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64040/
-----------------------------------------------------------
Review request for sentry, Hrishikesh Gadre, kalyan kumar kalvagadda, and Sergio Pena.
Repository: sentry
Description
-------
make the test case insensitive when comparing privileges
Diffs
-----
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java 0f4bb62
Diff: https://reviews.apache.org/r/64040/diff/1/
Testing
-------
unit test
Thanks,
Na Li
Re: Review Request 64040: SENTRY-2070: TestSentryShellSolr tests are
case sensitive to privileges
Posted by Hrishikesh Gadre via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64040/#review191761
-----------------------------------------------------------
Although this change looks harmless, I am trying to understand the motivation behind it. TestSentryShellSolr is passing consistently without this patch.
- Hrishikesh Gadre
On Nov. 22, 2017, 9:16 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64040/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2017, 9:16 p.m.)
>
>
> Review request for sentry, Hrishikesh Gadre, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> make the test case insensitive when comparing privileges
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java 0f4bb62
>
>
> Diff: https://reviews.apache.org/r/64040/diff/1/
>
>
> Testing
> -------
>
> unit test
>
>
> Thanks,
>
> Na Li
>
>