You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/20 21:07:51 UTC
[GitHub] [maven] michael-o opened a new pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
michael-o opened a new pull request #637:
URL: https://github.com/apache/maven/pull/637
Add args directly after the class name and leave users the option to override
with maven.config or CLI args.
This closes #637
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #637:
URL: https://github.com/apache/maven/pull/637#discussion_r772945412
##########
File path: apache-maven/src/assembly/shared/validate.cmd
##########
@@ -24,6 +24,7 @@
@REM MAVEN_BATCH_ECHO (Optional) Set to 'on' to enable the echoing of the batch commands.
@REM MAVEN_BATCH_PAUSE (Optional) set to 'on' to wait for a key stroke before ending.
@REM MAVEN_OPTS (Optional) Java runtime options used when Maven is executed.
+@REM MAVEN_ARGS (Optional) Arguments passed to Maven before CLI arguments.
Review comment:
While you may be right I think they sorted logically by usage. I make it alphabetically, no issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #637:
URL: https://github.com/apache/maven/pull/637#issuecomment-999358494
Must also end up in https://github.com/apache/maven-wrapper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #637:
URL: https://github.com/apache/maven/pull/637#issuecomment-998287566
> This needs to be documented somewhere as well.
You are right. I will locate the appropriate document before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #637:
URL: https://github.com/apache/maven/pull/637#discussion_r772943450
##########
File path: apache-maven/src/assembly/shared/validate.cmd
##########
@@ -24,6 +24,7 @@
@REM MAVEN_BATCH_ECHO (Optional) Set to 'on' to enable the echoing of the batch commands.
@REM MAVEN_BATCH_PAUSE (Optional) set to 'on' to wait for a key stroke before ending.
@REM MAVEN_OPTS (Optional) Java runtime options used when Maven is executed.
+@REM MAVEN_ARGS (Optional) Arguments passed to Maven before CLI arguments.
Review comment:
Assuming these are in alphabetic order, this is not the right location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #637:
URL: https://github.com/apache/maven/pull/637#issuecomment-999431963
@rfscholte While I agree those scripts are completely Maven 3. I.e, they would require to migrate to Maven 4 approach first. (reduced set). Cherry-picking pieces does not make sense. I can create a ticket to track this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #637:
URL: https://github.com/apache/maven/pull/637#issuecomment-998558401
>
I will supersede #602 with two alternative PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #637:
URL: https://github.com/apache/maven/pull/637#issuecomment-998582931
@rfscholte Updated inline scripts and add https://github.com/apache/maven-site/pull/280.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #637:
URL: https://github.com/apache/maven/pull/637#issuecomment-998550119
I guess this means we can close #602?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #637: [MNG-7193] Introduce MAVEN_ARGS environment variable
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #637:
URL: https://github.com/apache/maven/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org