[GitHub] spark pull request #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff te...

[yogeshg <gi...@git.apache.org>]

Github user yogeshg commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20904#discussion_r179267921
  
    --- Diff: python/pyspark/ml/stat.py ---
    @@ -134,6 +134,63 @@ def corr(dataset, column, method="pearson"):
             return _java2py(sc, javaCorrObj.corr(*args))
     
     
    +class KolmogorovSmirnovTest(object):
    +    """
    +    .. note:: Experimental
    +
    +    Conduct the two-sided Kolmogorov Smirnov (KS) test for data sampled from a
    --- End diff --
    
    We can add a one line description and then a paragraph full of description, this way we'll get [docs](https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.ml.stat.package) consistent with the rest of the tests in the package.
    
    ```scala
    /**
    ...
     * Conduct two-sided Kolmogorov Smirnov (KS) test for data sampled from a continuous distribution.
     * 
     * By comparing the largest difference between the empirical cumulative
    ...
     */
    ```
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org