You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "soumitra-st (via GitHub)" <gi...@apache.org> on 2023/05/17 02:23:22 UTC
[GitHub] [pinot] soumitra-st opened a new pull request, #10771: Enable case insensitivity by default
soumitra-st opened a new pull request, #10771:
URL: https://github.com/apache/pinot/pull/10771
This PR changes the default value of enable.case.insensitive configuration to true to make Pinot case insensitive by default.
## Old data in Pinot cluster - case insensitive query fails
<img width="906" alt="old-table-case-insensitive-query-fails" src="https://github.com/apache/pinot/assets/127247229/d16234be-b134-4101-af01-a9e6d1d42445">
## Old data in Pinot cluster - case insensitive query works after deploying new broker with the fix
<img width="911" alt="old-table-case-insensitive-query-compatible" src="https://github.com/apache/pinot/assets/127247229/d2e15f70-8372-4672-bf1d-cbad7569ac17">
## Populated new table with the fix - case insensitive query works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mayankshriv commented on pull request #10771: Enable case insensitivity by default
Posted by "mayankshriv (via GitHub)" <gi...@apache.org>.
mayankshriv commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1571004572
@Jackie-Jiang Any other open concerns here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #10771: Enable case insensitivity by default
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #10771:
URL: https://github.com/apache/pinot/pull/10771#discussion_r1198031649
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -270,8 +270,8 @@ public void start()
// Initialize FunctionRegistry before starting the broker request handler
FunctionRegistry.init();
boolean caseInsensitive =
- _brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, false) || _brokerConf.getProperty(
- Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, false);
+ _brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, true) || _brokerConf.getProperty(
+ Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, true);
Review Comment:
suggest making it a parameter in `CommonConstants.Helix.DEFAULT_CASE_INSENSITIVITY_KEY`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on pull request #10771: Enable case insensitivity by default
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1553402706
I'm up for making the default behavior to case in-sensitive.
Shall we also prevent users creating tables in a case-sensitive fashion anytime?(you can create a follow up PR)
Let's making sure the existing cluster with case insensitive = false won't be automatically turned on after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #10771: Enable case insensitivity by default
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1554801098
yes I agree that we should follow the case insensitivity goal. in fact PostgresQL does it more specifically:
- unquoted names are case-insensitive. Thus `SELECT * FROM hello` and `SELECT * FROM HELLO` are equivalent.
- However, quoted names are case-sensitive. `SELECT * FROM "hello"` is not equivalent to `SELECT * FROM "HELLO"`.
i think my concern is majorly on backward-compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] soumitra-st commented on pull request #10771: Enable case insensitivity by default
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1560296083
This is getting a bit trickier than I thought, mostly because of the deprecated property. @Jackie-Jiang @walterddr @xiangfu0 , if you can write a few lines about the expected behavior, considering the deprecated property, then I can modify the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10771: Enable case insensitivity by default
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #10771:
URL: https://github.com/apache/pinot/pull/10771#discussion_r1214874857
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -315,10 +315,8 @@ public void onInstanceConfigChange(List<InstanceConfig> instanceConfigs, Notific
HelixConfigScope helixConfigScope =
new HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.CLUSTER).forCluster(_helixClusterName).build();
Map<String, String> configs = _helixAdmin.getConfig(helixConfigScope,
- Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
- boolean caseInsensitive =
- Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY)) || Boolean.parseBoolean(
- configs.get(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
+ Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY));
+ boolean caseInsensitive = Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY));
Review Comment:
If the key is not configured, `caseInsensitive` should be true. Currently it will be false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10771: Enable case insensitivity by default
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10771:
URL: https://github.com/apache/pinot/pull/10771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] soumitra-st commented on a diff in pull request #10771: Enable case insensitivity by default
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on code in PR #10771:
URL: https://github.com/apache/pinot/pull/10771#discussion_r1214937624
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -315,10 +315,8 @@ public void onInstanceConfigChange(List<InstanceConfig> instanceConfigs, Notific
HelixConfigScope helixConfigScope =
new HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.CLUSTER).forCluster(_helixClusterName).build();
Map<String, String> configs = _helixAdmin.getConfig(helixConfigScope,
- Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
- boolean caseInsensitive =
- Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY)) || Boolean.parseBoolean(
- configs.get(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
+ Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY));
+ boolean caseInsensitive = Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY));
Review Comment:
Addressed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] soumitra-st commented on pull request #10771: Enable case insensitivity by default
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1557711547
Pushed the code as described in option 2 above.
Changed the config using /cluster/configs API, to ensure that if any of enable.case.insensitive or enable.case.insensitive.pql is set to false, then Pinot is case sensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] soumitra-st commented on pull request #10771: Enable case insensitivity by default
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1557189891
> Let's also make sure the existing cluster with case insensitive = false won't be automatically turned on after this change.
@xiangfu0 , one question here:
Current code is:
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, false)
||
_brokerConf.getProperty(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, false);
Which means, by default Pinot is case sensitive, and if any of the two properties (Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY) are set to true, Pinot becomes case insensitive.
There are two possible changes:
1. Change the default to true, and ||
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, true)
||
_brokerConf.getProperty(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, true);
Now, Pinot is case insensitive by default, but BOTH of these properties (Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY) would have to be set to false, to make Pinot case sensitive.
2. Change the default to true, and &&
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, true)
&&
_brokerConf.getProperty(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, true);
In this case, Pinot is case insensitive by default, but ANY of these properties (Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY) can be set to false, to make Pinot case sensitive.
My preference is 2, since Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY is a deprecated property, hence asking users to set both does not make sense as in option 1.
Please advise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10771: Enable case insensitivity by default
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #10771:
URL: https://github.com/apache/pinot/pull/10771#discussion_r1203194721
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -314,7 +314,7 @@ public void onInstanceConfigChange(List<InstanceConfig> instanceConfigs, Notific
Map<String, String> configs = _helixAdmin.getConfig(helixConfigScope,
Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
boolean caseInsensitive =
- Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY)) || Boolean.parseBoolean(
+ Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY)) && Boolean.parseBoolean(
Review Comment:
This is incorrect
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java:
##########
@@ -79,7 +79,8 @@ private static void setupHelixClusterIfNeeded(String helixClusterName, String zk
new HelixConfigScopeBuilder(ConfigScopeProperty.CLUSTER).forCluster(helixClusterName).build();
Map<String, String> configMap = new HashMap<>();
configMap.put(ZKHelixManager.ALLOW_PARTICIPANT_AUTO_JOIN, Boolean.toString(true));
- configMap.put(ENABLE_CASE_INSENSITIVE_KEY, Boolean.toString(false));
+ configMap.put(ENABLE_CASE_INSENSITIVE_KEY, Boolean.toString(DEFAULT_ENABLE_CASE_INSENSITIVE));
+ configMap.put(DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, Boolean.toString(DEFAULT_ENABLE_CASE_INSENSITIVE));
Review Comment:
Let's not put the deprecated key
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -270,8 +270,9 @@ public void start()
// Initialize FunctionRegistry before starting the broker request handler
FunctionRegistry.init();
boolean caseInsensitive =
- _brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, false) || _brokerConf.getProperty(
- Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, false);
+ _brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEFAULT_ENABLE_CASE_INSENSITIVE)
Review Comment:
Not introduced in this PR, but the correct way to handle it should be:
1. Check if the key is explicitly configured
2. If so, use the value
3. If not, fall back to the deprecated key
Currently, if the official key is configured as `true`, but the deprecated key is configured as `false`, the overall result is `false` which is unexpected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mayankshriv commented on pull request #10771: Enable case insensitivity by default
Posted by "mayankshriv (via GitHub)" <gi...@apache.org>.
mayankshriv commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1564877775
> This is getting a bit trickier than I thought, mostly because of the deprecated property. @Jackie-Jiang @walterddr @xiangfu0 , if you can write a few lines about the expected behavior, considering the deprecated property, then I can modify the PR accordingly.
I see `enable.case.insensitive.pql` as the deprecated key. Since we no longer support PQL, we can simply ignore/remove the deprecated key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] soumitra-st commented on pull request #10771: Enable case insensitivity by default
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1565782702
Removed the deprecated property enable.case.insensitive.pql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on pull request #10771: Enable case insensitivity by default
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1550598880
I think this change will resolce this [issue](https://github.com/apache/pinot/issues/10734) as well. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10771: Enable case insensitivity by default
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1550621694
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10771?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10771](https://app.codecov.io/gh/apache/pinot/pull/10771?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (125d5d1) into [master](https://app.codecov.io/gh/apache/pinot/commit/12d86902a84d4bc78b6f2f7bc8bd002659ee61cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (12d8690) will **decrease** coverage by `56.66%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #10771 +/- ##
=============================================
- Coverage 70.32% 13.67% -56.66%
+ Complexity 6473 439 -6034
=============================================
Files 2157 2103 -54
Lines 116016 113526 -2490
Branches 17552 17255 -297
=============================================
- Hits 81586 15522 -66064
- Misses 28731 96739 +68008
+ Partials 5699 1265 -4434
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.67% <50.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10771?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/pinot/broker/broker/helix/BaseBrokerStarter.java](https://app.codecov.io/gh/apache/pinot/pull/10771?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jhc2VCcm9rZXJTdGFydGVyLmphdmE=) | `71.25% <0.00%> (-5.12%)` | :arrow_down: |
| [...ot/controller/helix/core/util/HelixSetupUtils.java](https://app.codecov.io/gh/apache/pinot/pull/10771?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=) | `91.39% <100.00%> (ø)` | |
... and [1706 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10771/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org