You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/02 10:12:59 UTC
[jira] [Commented] (BEAM-879) Renaming DeDupExample to
DistinctExample
[ https://issues.apache.org/jira/browse/BEAM-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714692#comment-15714692 ]
ASF GitHub Bot commented on BEAM-879:
-------------------------------------
GitHub user nssalian opened a pull request:
https://github.com/apache/incubator-beam/pull/1489
[BEAM-879]: Renaming DeDupExample to DistinctExample
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
In BEAM-239, we renamed DeDupExampleTest to DistinctExampleTest.
Need to modify DeDupExample to DistinctExample as well.
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/incubator-beam BEAM-879
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1489.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1489
----
commit 604de141c0995fa7426fc2525539adb4baa7eb84
Author: Neelesh Srinivas Salian <ns...@cloudera.com>
Date: 2016-12-02T04:28:43Z
BEAM-879: Changing DeDupExample to DistinctExample
----
> Renaming DeDupExample to DistinctExample
> ----------------------------------------
>
> Key: BEAM-879
> URL: https://issues.apache.org/jira/browse/BEAM-879
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Neelesh Srinivas Salian
> Assignee: Neelesh Srinivas Salian
> Priority: Trivial
>
> In BEAM-239, we renamed DeDupExampleTest to DistinctExampleTest.
> Need to modify DeDupExample to DistinctExample as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)