You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/06/09 19:46:07 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #6890: Add user details/edit page to TPv2

ocket8888 opened a new pull request, #6890:
URL: https://github.com/apache/trafficcontrol/pull/6890

   This PR adds a details/edit page for users to TPv2, and implements the context menu for the users table (except "View User Changelogs" which will be done in the future). It also refactors generic tables a bit to allow link menu items to dynamically generate their `href`s, and allows links to be disabled.
   
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Portal (experimental v2)
   
   ## What is the best way to verify this PR?
   Make sure all the associated tests I wrote are passing
   
   ## PR submission checklist
   - [x] This PR has tests
   - [ ] This PR has documentation
   - [ ] This PR has a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on pull request #6890: Add user details/edit page to TPv2

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #6890:
URL: https://github.com/apache/trafficcontrol/pull/6890#issuecomment-1152592182

   Note: I didn't write e2e tests yet because that will get much simpler when I put in the work to create/delete users


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] shamrickus merged pull request #6890: Add user details/edit page to TPv2

Posted by GitBox <gi...@apache.org>.
shamrickus merged PR #6890:
URL: https://github.com/apache/trafficcontrol/pull/6890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org