You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Ismaël Mejía <ie...@gmail.com> on 2020/02/25 12:43:36 UTC
[VOTE] Vendored Dependencies Release Byte Buddy 1.10.8
Please review the release of the following artifacts that we vendor:
* beam-vendor-bytebuddy-1_10_8
Hi everyone,
Please review and vote on the release candidate #1 for the version 0.1, as
follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* the official Apache source release to be deployed to dist.apache.org [1],
which is signed with the key with fingerprint
3415631729E15B33051ADB670A9DAF6713B86349 [2],
* all artifacts to be deployed to the Maven Central Repository [3],
* commit hash "0756edfba7c682b1e75f4691c0ecb38a1dc9d16a" [4],
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Release Manager
[1] https://dist.apache.org/repos/dist/dev/beam/vendor/
[2] https://dist.apache.org/repos/dist/release/beam/KEYS
[3] https://repository.apache.org/content/repositories/orgapachebeam-1093/
[4]
https://github.com/apache/beam/commit/0756edfba7c682b1e75f4691c0ecb38a1dc9d16a
Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8
Posted by Ismaël Mejía <ie...@gmail.com>.
Thanks Luke there is indeed an extra module-info.class in the vendored jar.
This vote is cancelled. A new vote will be opened once the fix is merged.
PTAL https://github.com/apache/beam/pull/10970
On Tue, Feb 25, 2020 at 6:39 PM Luke Cwik <lc...@google.com> wrote:
> -1
>
> The jar contains META-INF/versions/9/module-info.class copied over from
> bytebuddy containing:
>
> module net.bytebuddy {
> requires static java.instrument;
> requires static jdk.unsupported;
> requires static net.bytebuddy.agent;
>
> exports net.bytebuddy;
> exports net.bytebuddy.agent.builder;
> exports net.bytebuddy.asm;
> exports net.bytebuddy.build;
> exports net.bytebuddy.description;
> exports net.bytebuddy.description.annotation;
> exports net.bytebuddy.description.enumeration;
> exports net.bytebuddy.description.field;
> exports net.bytebuddy.description.method;
> exports net.bytebuddy.description.modifier;
> exports net.bytebuddy.description.type;
> exports net.bytebuddy.dynamic;
> exports net.bytebuddy.dynamic.loading;
> exports net.bytebuddy.dynamic.scaffold;
> exports net.bytebuddy.dynamic.scaffold.inline;
> exports net.bytebuddy.dynamic.scaffold.subclass;
> exports net.bytebuddy.implementation;
> exports net.bytebuddy.implementation.attribute;
> exports net.bytebuddy.implementation.auxiliary;
> exports net.bytebuddy.implementation.bind;
> exports net.bytebuddy.implementation.bind.annotation;
> exports net.bytebuddy.implementation.bytecode;
> exports net.bytebuddy.implementation.bytecode.assign;
> exports net.bytebuddy.implementation.bytecode.assign.primitive;
> exports net.bytebuddy.implementation.bytecode.assign.reference;
> exports net.bytebuddy.implementation.bytecode.collection;
> exports net.bytebuddy.implementation.bytecode.constant;
> exports net.bytebuddy.implementation.bytecode.member;
> exports net.bytebuddy.matcher;
> exports net.bytebuddy.pool;
> exports net.bytebuddy.utility;
> exports net.bytebuddy.utility.privilege;
> exports net.bytebuddy.utility.visitor;
> exports net.bytebuddy.jar.asm;
> exports net.bytebuddy.jar.asm.signature;
> exports net.bytebuddy.jar.asm.commons;
> }
>
>
> On Tue, Feb 25, 2020 at 8:15 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
>> +1
>>
>> Regards
>> JB
>>
>> Le mar. 25 f?vr. 2020 ? 13:43, Isma?l Mej?a <ie...@gmail.com> a ?crit :
>>
>>> Please review the release of the following artifacts that we vendor:
>>> * beam-vendor-bytebuddy-1_10_8
>>>
>>> Hi everyone,
>>> Please review and vote on the release candidate #1 for the version 0.1,
>>> as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> The complete staging area is available for your review, which includes:
>>> * the official Apache source release to be deployed to dist.apache.org
>>> [1], which is signed with the key with fingerprint
>>> 3415631729E15B33051ADB670A9DAF6713B86349 [2],
>>> * all artifacts to be deployed to the Maven Central Repository [3],
>>> * commit hash "0756edfba7c682b1e75f4691c0ecb38a1dc9d16a" [4],
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> Release Manager
>>>
>>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>>> [3]
>>> https://repository.apache.org/content/repositories/orgapachebeam-1093/
>>> [4]
>>> https://github.com/apache/beam/commit/0756edfba7c682b1e75f4691c0ecb38a1dc9d16a
>>>
>>>
Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8
Posted by Luke Cwik <lc...@google.com>.
-1
The jar contains META-INF/versions/9/module-info.class copied over from
bytebuddy containing:
module net.bytebuddy {
requires static java.instrument;
requires static jdk.unsupported;
requires static net.bytebuddy.agent;
exports net.bytebuddy;
exports net.bytebuddy.agent.builder;
exports net.bytebuddy.asm;
exports net.bytebuddy.build;
exports net.bytebuddy.description;
exports net.bytebuddy.description.annotation;
exports net.bytebuddy.description.enumeration;
exports net.bytebuddy.description.field;
exports net.bytebuddy.description.method;
exports net.bytebuddy.description.modifier;
exports net.bytebuddy.description.type;
exports net.bytebuddy.dynamic;
exports net.bytebuddy.dynamic.loading;
exports net.bytebuddy.dynamic.scaffold;
exports net.bytebuddy.dynamic.scaffold.inline;
exports net.bytebuddy.dynamic.scaffold.subclass;
exports net.bytebuddy.implementation;
exports net.bytebuddy.implementation.attribute;
exports net.bytebuddy.implementation.auxiliary;
exports net.bytebuddy.implementation.bind;
exports net.bytebuddy.implementation.bind.annotation;
exports net.bytebuddy.implementation.bytecode;
exports net.bytebuddy.implementation.bytecode.assign;
exports net.bytebuddy.implementation.bytecode.assign.primitive;
exports net.bytebuddy.implementation.bytecode.assign.reference;
exports net.bytebuddy.implementation.bytecode.collection;
exports net.bytebuddy.implementation.bytecode.constant;
exports net.bytebuddy.implementation.bytecode.member;
exports net.bytebuddy.matcher;
exports net.bytebuddy.pool;
exports net.bytebuddy.utility;
exports net.bytebuddy.utility.privilege;
exports net.bytebuddy.utility.visitor;
exports net.bytebuddy.jar.asm;
exports net.bytebuddy.jar.asm.signature;
exports net.bytebuddy.jar.asm.commons;
}
On Tue, Feb 25, 2020 at 8:15 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:
> +1
>
> Regards
> JB
>
> Le mar. 25 f?vr. 2020 ? 13:43, Isma?l Mej?a <ie...@gmail.com> a ?crit :
>
>> Please review the release of the following artifacts that we vendor:
>> * beam-vendor-bytebuddy-1_10_8
>>
>> Hi everyone,
>> Please review and vote on the release candidate #1 for the version 0.1,
>> as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> The complete staging area is available for your review, which includes:
>> * the official Apache source release to be deployed to dist.apache.org
>> [1], which is signed with the key with fingerprint
>> 3415631729E15B33051ADB670A9DAF6713B86349 [2],
>> * all artifacts to be deployed to the Maven Central Repository [3],
>> * commit hash "0756edfba7c682b1e75f4691c0ecb38a1dc9d16a" [4],
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Release Manager
>>
>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
>> [3]
>> https://repository.apache.org/content/repositories/orgapachebeam-1093/
>> [4]
>> https://github.com/apache/beam/commit/0756edfba7c682b1e75f4691c0ecb38a1dc9d16a
>>
>>
Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1
Regards
JB
Le mar. 25 f?vr. 2020 ? 13:43, Isma?l Mej?a <ie...@gmail.com> a ?crit :
> Please review the release of the following artifacts that we vendor:
> * beam-vendor-bytebuddy-1_10_8
>
> Hi everyone,
> Please review and vote on the release candidate #1 for the version 0.1, as
follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * the official Apache source release to be deployed to
[dist.apache.org](http://dist.apache.org) [1], which is signed with the key
with fingerprint 3415631729E15B33051ADB670A9DAF6713B86349 [2],
> * all artifacts to be deployed to the Maven Central Repository [3],
> * commit hash "0756edfba7c682b1e75f4691c0ecb38a1dc9d16a" [4],
>
> The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1]
[https://dist.apache.org/repos/dist/dev/beam/vendor/](https://dist.apache.org/repos/dist/dev/beam/vendor/)
> [2]
[https://dist.apache.org/repos/dist/release/beam/KEYS](https://dist.apache.org/repos/dist/release/beam/KEYS)
> [3]
[https://repository.apache.org/content/repositories/orgapachebeam-1093/](https://repository.apache.org/content/repositories/orgapachebeam-1093/)
> [4]
[https://github.com/apache/beam/commit/0756edfba7c682b1e75f4691c0ecb38a1dc9d16a](https://github.com/apache/beam/commit/0756edfba7c682b1e75f4691c0ecb38a1dc9d16a)
>
>
Re: [VOTE] Vendored Dependencies Release Byte Buddy 1.10.8
Posted by Reuven Lax <re...@google.com>.
+1
On Tue, Feb 25, 2020 at 4:44 AM Ismaël Mejía <ie...@gmail.com> wrote:
> Please review the release of the following artifacts that we vendor:
> * beam-vendor-bytebuddy-1_10_8
>
> Hi everyone,
> Please review and vote on the release candidate #1 for the version 0.1, as
> follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * the official Apache source release to be deployed to dist.apache.org
> [1], which is signed with the key with fingerprint
> 3415631729E15B33051ADB670A9DAF6713B86349 [2],
> * all artifacts to be deployed to the Maven Central Repository [3],
> * commit hash "0756edfba7c682b1e75f4691c0ecb38a1dc9d16a" [4],
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release Manager
>
> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/
> [2] https://dist.apache.org/repos/dist/release/beam/KEYS
> [3] https://repository.apache.org/content/repositories/orgapachebeam-1093/
> [4]
> https://github.com/apache/beam/commit/0756edfba7c682b1e75f4691c0ecb38a1dc9d16a
>
>