You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/26 06:25:46 UTC

[GitHub] feng-tao commented on a change in pull request #4594: [AIRFLOW-3771] Minor refactor securityManager

feng-tao commented on a change in pull request #4594: [AIRFLOW-3771] Minor refactor securityManager
URL: https://github.com/apache/airflow/pull/4594#discussion_r251190082
 
 

 ##########
 File path: airflow/www/security.py
 ##########
 @@ -192,11 +192,14 @@ def init_role(self, role_name, role_vms, role_perms):
             self.get_session.merge(role)
             self.get_session.commit()
         else:
-            logging.info('Existing permissions for the role:%s within the database will persist.', role_name)
+            self.log.info('Existing permissions for the role:%s within the database will persist.', role_name)
 
     def get_user_roles(self, user=None):
         """
         Get all the roles associated with the user.
+
+        :param user
 
 Review comment:
   updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services