[jira] [Commented] (BIGTOP-1685) puppet hadoop: Remove useless use of explicit hiera lookup

["Michael Weiser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342096#comment-14342096 ] 

Michael Weiser commented on BIGTOP-1685:
----------------------------------------

Hi [~cos],

the explicit use of the hiera() function to do the lookup is not necessary since adding them as class parameters with their defaults will do exactly the same. The lookup key used ('hadoop::common_hdfs::...') also directly corresponds to the class namespace. The use of hiera() is left over from when I was not sure how and where the variable values need to be constructed from other values and defaults.

> puppet hadoop: Remove useless use of explicit hiera lookup
> ----------------------------------------------------------
>
>                 Key: BIGTOP-1685
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1685
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: 0.8.0
>            Reporter: Michael Weiser
>            Assignee: Michael Weiser
>             Fix For: 0.9.0
>
>         Attachments: 0001-BIGTOP-1685-Remove-useless-use-of-explicit-hiera-loo.patch
>
>
> Two explicit hiera lookups are left over from reworking the variable
> lookup logic for ssh fencing key parameters. Those can go now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)